[Homepage] Replace DevPlat cards with video #17403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
GregBrimble,
WalshyDev,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
KianNH
commented
Oct 8, 2024
| </Card> | ||
| )) | ||
| title === "Developer Platform" ? ( | ||
| <div class="[&>article]:gap-0"> |
Member
Author
There was a problem hiding this comment.
We don't want a title on this card, and we need to override the gap because of the now-empty <p> tag still causing it to be calculated.
github-actions
bot
assigned
GregBrimble,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
Deploying cloudflare-docs with
|
| Latest commit: |
a407484
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aef672bd.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-13986.cloudflare-docs-7ou.pages.dev |
KimJ15
approved these changes
Oct 9, 2024
Collaborator
There was a problem hiding this comment.
Chatted with @abstergail and i'm fine to add this now. She has a few recommendations, then we can merge.
Oxyjun
approved these changes
Nov 21, 2024
pedrosousa
approved these changes
Nov 21, 2024
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* [Homepage] Replace DevPlat cards with video * updating thumbnail * adding the cf-stack image to assets --------- Co-authored-by: Jason Farber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace DevPlat cards with video
Screenshots (optional)
Before:
After:
