Skip to content

Move to Workers #17502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 15, 2024
Merged

Move to Workers #17502

merged 7 commits into from
Oct 15, 2024

Conversation

@GregBrimble
Copy link
Contributor

@GregBrimble GregBrimble commented Oct 14, 2024 •
edited
Loading

So, things to do:

  • Apply changes to Snippet (see chat) (already deployed).
  • Apply changes to Snippet CI (see chat).
  • Merge this (already tested in production).
  • Disable Custom Domain in Pages project.
  • Bump redirects-in-workers with customizable limits.
  • Remove the Rules which are adding double slashes.
  • Remove the code from this Worker for stripping double slashes.

Later:

  • Update all the preview PR comments to point to the Worker rather than the Pages project.
  • Delete the Pages project.

@GregBrimble GregBrimble requested a review from a team as a code owner October 14, 2024 04:47
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024 •
edited
Loading

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f8c0b4a
Status: ✅  Deploy successful!
Preview URL: https://d6e6ad04.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://move-to-workers.cloudflare-docs-7ou.pages.dev

View logs

@github-actions github-actions bot added size/s and removed size/xs labels Oct 14, 2024
@GregBrimble GregBrimble requested a review from a team as a code owner October 14, 2024 05:43
@GregBrimble GregBrimble force-pushed the move-to-workers branch 2 times, most recently from 30b4d29 to 6d38af4 Compare October 14, 2024 05:56
@github-actions github-actions bot added size/xl and removed size/s labels Oct 15, 2024
@GregBrimble GregBrimble enabled auto-merge (squash) October 15, 2024 14:36
@GregBrimble GregBrimble merged commit 9159acf into production Oct 15, 2024
11 checks passed
@GregBrimble GregBrimble deleted the move-to-workers branch October 15, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KianNH KianNH KianNH approved these changes

@pedrosousa pedrosousa Awaiting requested review from pedrosousa

@haleycode haleycode Awaiting requested review from haleycode

@kristianfreeman kristianfreeman Awaiting requested review from kristianfreeman

@maxvp maxvp Awaiting requested review from maxvp

@marciocloudflare marciocloudflare Awaiting requested review from marciocloudflare

@WalshyDev WalshyDev Awaiting requested review from WalshyDev

Assignees

@KianNH KianNH

Labels

size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GregBrimble @KianNH @pedrosousa @dcpena @haleycode @patriciasantaana