-
Notifications
You must be signed in to change notification settings - Fork 10.4k
fix code formatting #17505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix code formatting #17505
Conversation
|
@cloudflare/workers-docs @cloudflare/pcx-technical-writing can this be merged? |
|
Hi @vicb |
|
Hey @pedrosousa, Thanks for your help. I have a few questions for you:
Using prettier is great - there are a lot of inconsistencies in the docs. Why don't we format all the docs with that instead of doing it only on file save? It would require to update the format script to include md and mdx files. We would also probably need to add a few ignored folders. I don't see any blockers on doing that and we would have a consistent formatting. If the whole docs are formatted some PR might get merge conflicts but it would be easy to format them to remove the conflicts. I can help with that if needed. Let me know what you think, is this has been discussed already or if I need to create a feature request. The second question is to understand how PRs are merged in this repo. This PR is now approved, when will it get merged? Thanks. |
|
The use of I'll merge the PR now that the checks have finished. Usually the assigned tech writer handles the review and the merge, but this may take a few days. Other internal folks with write access can also approve and merge PRs (usually when they're smaller or urgent). |
|
Thanks @pedrosousa!
Let me know if there is anything I can help with here. Inconsistencies are bothering me so I would love to help unblock a global update. |
Summary
fix formatting
Documentation checklist