Add Puppeteer tests #17523
Merged
Add Puppeteer tests #17523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregBrimble
requested review from
a team,
KianNH,
WalshyDev,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
GregBrimble
force-pushed
the
omg-puppeteer-tests
branch
from
7c7789d to
cf7c619
Compare
Deploying cloudflare-docs with
|
| Latest commit: |
cf7c619
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6049f838.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://omg-puppeteer-tests.cloudflare-docs-7ou.pages.dev |
12 tasks
GregBrimble
force-pushed
the
add-tests
branch
from
1359571 to
9f4aad5
Compare
GregBrimble
force-pushed
the
omg-puppeteer-tests
branch
from
cf7c619 to
509a272
Compare
KianNH
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Puppeteer tests! So awesome that this works!
Separately, I'll write up a guide for our users on how to do this because this is absolutely killer.Done: cloudflare/workers-sdk#6967 and #17527