Skip to content

[DO] Relocating the limit increase box away from the footnotes for clarity. #17575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2024
Merged

[DO] Relocating the limit increase box away from the footnotes for clarity. #17575

merged 3 commits into from
Oct 16, 2024

Conversation

@Oxyjun
Copy link
Contributor

@Oxyjun Oxyjun commented Oct 16, 2024 •
edited
Loading

Summary

  1. Relocating the limit increase note box away from the footnotes for less confusion (we won't be increasing the limit on a per-account basis)
  2. Using the new footnote component. Technically, this solves 1 as well, but have relocated the box away anyway.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@Oxyjun Oxyjun requested review from a team, elithrar, joshthoward and vy-ton as code owners October 16, 2024 15:47
@github-actions github-actions bot added the product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ label Oct 16, 2024
@github-actions github-actions bot added size/s and removed size/xs labels Oct 16, 2024
@Oxyjun Oxyjun self-assigned this Oct 16, 2024
marciocloudflare
marciocloudflare approved these changes Oct 16, 2024
View reviewed changes
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2024 •
edited
Loading

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 87ca42b
Status: ✅  Deploy successful!
Preview URL: https://bef22bf8.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://jun-do-limit-box-relocation.cloudflare-docs-7ou.pages.dev

View logs

@Oxyjun Oxyjun enabled auto-merge (squash) October 16, 2024 16:02
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/durable-objects/platform/limits/ https://jun-do-limit-box-relocation.cloudflare-docs-7ou.pages.dev/durable-objects/platform/limits/

@Oxyjun Oxyjun merged commit 0d8a917 into production Oct 16, 2024
9 checks passed
@Oxyjun Oxyjun deleted the jun/do/limit-box-relocation branch October 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marciocloudflare marciocloudflare marciocloudflare approved these changes

@elithrar elithrar Awaiting requested review from elithrar elithrar is a code owner

@vy-ton vy-ton Awaiting requested review from vy-ton vy-ton is a code owner

@joshthoward joshthoward Awaiting requested review from joshthoward joshthoward is a code owner

Assignees

@elithrar elithrar

@joshthoward joshthoward

@vy-ton vy-ton

@Oxyjun Oxyjun

Labels

product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Oxyjun @marciocloudflare @elithrar @joshthoward @vy-ton