[Docs Site] Fix footnotes with multiple references #17576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
GregBrimble,
WalshyDev,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
Oxyjun
approved these changes
Oct 16, 2024
Deploying cloudflare-docs with
|
| Latest commit: |
6ec3cc2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://28cc8a03.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-14165.cloudflare-docs-7ou.pages.dev |
github-actions
bot
assigned
GregBrimble,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
Contributor
|
Got an example of where this is used? |
Member
Author
https://developers.cloudflare.com/durable-objects/platform/limits/ vs. https://kian-pcx-14165.cloudflare-docs-7ou.pages.dev/durable-objects/platform/limits/ |
GregBrimble
reviewed
Oct 16, 2024
|
|
||
| const fnrefs = document.querySelectorAll<HTMLAnchorElement>( | ||
| `#${note.id.replace("fn", "fnref")}`, | ||
| `a[id^='${note.id.replace("fn", "fnref")}']`, |
Contributor
There was a problem hiding this comment.
Oh, does duplicate ones do something like id="blah-2"? Is that why you're switching to ^=?
Member
Author
There was a problem hiding this comment.
Yep! You get user-content-fnref-2 and user-content-fnref-2-2 😢
GregBrimble
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix footnotes with multiple references