Skip to content

[Docs Site] Fix footnotes with multiple references #17576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[Docs Site] Fix footnotes with multiple references #17576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/scripts/footnotes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if (footnotes) {
const content = note.querySelector("p") as HTMLParagraphElement;

const fnrefs = document.querySelectorAll<HTMLAnchorElement>(
`#${note.id.replace("fn", "fnref")}`,
`a[id^='${note.id.replace("fn", "fnref")}']`,
Copy link
Contributor

@GregBrimble GregBrimble Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, does duplicate ones do something like id="blah-2"? Is that why you're switching to ^=?

Copy link
Member Author

@KianNH KianNH Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! You get user-content-fnref-2 and user-content-fnref-2-2 😢

);

for (const fnref of fnrefs) {
Expand Down
Loading