Extracts compatibility-flags out of compatibility-dates #17900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
requested review from
a team,
GregBrimble,
Oxyjun,
ToriLindsay,
WalshyDev,
aninibread,
celso,
elithrar,
irvinebroque,
jasnell,
joshthoward,
maheshwarip,
mchenco,
meddulla,
mikenomitch,
sejoker,
tanushree-sharma,
toddmantell and
vy-ton
as code owners
github-actions
bot
added
size/m
product:browser-rendering
product:durable-objects
github-actions
bot
assigned
dcpena,
haleycode,
patriciasantaana,
pedrosousa and
elithrar
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
src/content/docs/workers/testing/vitest-integration/isolation-and-concurrency.mdx
Show resolved
Hide resolved
Contributor
Author
|
@irvinebroque Thanks for the review, I have updated the content, please take another look. |
Contributor
Author
|
PR rebased to resolve a merge conflict |
irvinebroque
approved these changes
Nov 7, 2024
While the concepts are related they are not the same. compatibility-flags will grow as we had more flags and deserves a separate page. This also has the benefit to have add an entry in the side bar. Having to click on "Configuration > Compatibility dates" to get info on the Compatibility flags is counter-intuitive. I have updated internal links to point to the newly added flag page. Unfortunately external links to a given flag (i.e. "workers/configuration/compatibility-dates/#nodejs-compatibility-flag") will not point to that flag but to the top of the "Compatibility date". This is a limitation of the redirect mechanism on the site which can not redirect a fragment. There are only a few changes in the content for the new flag page. I extracted a sentence from the first section into as the subtitle and I fixed a typo. The only other change is updating the CODEOWNERS of the new page to the same as the page is was extracted from.
Contributor
Author
|
PR rebased to resolve a merge conflict |
Contributor
|
@ToriLindsay @dcpena - can we get ✅ to merge this? |
dcpena
approved these changes
Nov 7, 2024
Contributor
Author
|
Thanks all for the help getting this merged |
This was referenced Nov 12, 2024
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Extracts compatibility-flags out of compatibility-dates While the concepts are related they are not the same. compatibility-flags will grow as we had more flags and deserves a separate page. This also has the benefit to have add an entry in the side bar. Having to click on "Configuration > Compatibility dates" to get info on the Compatibility flags is counter-intuitive. I have updated internal links to point to the newly added flag page. Unfortunately external links to a given flag (i.e. "workers/configuration/compatibility-dates/#nodejs-compatibility-flag") will not point to that flag but to the top of the "Compatibility date". This is a limitation of the redirect mechanism on the site which can not redirect a fragment. There are only a few changes in the content for the new flag page. I extracted a sentence from the first section into as the subtitle and I fixed a typo. The only other change is updating the CODEOWNERS of the new page to the same as the page is was extracted from. * fixup! Extracts compatibility-flags out of compatibility-dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While the concepts are related they are not the same.
compatibility-flags will grow as we had more flags and deserves a separate page. This also has the benefit to have add an entry in the side bar. Having to click on "Configuration > Compatibility dates" to get info on the Compatibility flags is counter-intuitive.
I have updated internal links to point to the newly added flag page. Unfortunately external links to a given flag (i.e. "workers/configuration/compatibility-dates/#nodejs-compatibility-flag") will not point to that flag but to the top of the "Compatibility date". This is a limitation of the redirect mechanism on the site which can not redirect a fragment.
There are only a few changes in the content for the new flag page. I extracted a sentence from the first section into as the subtitle and I fixed a typo. The only other change is updating the CODEOWNERS of the new page to the same as the page is was extracted from.
Documentation checklist