fix node:crypto API support #17952
Merged
fix node:crypto API support #17952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
requested review from
a team,
GregBrimble,
irvinebroque,
jasnell and
mikenomitch
as code owners
GregBrimble
approved these changes
Nov 5, 2024
Contributor
Author
|
Thanks Greg |
elithrar
pushed a commit
that referenced
this pull request
Nov 6, 2024
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
node:cryptokeys API are not available.While those exist, they would throw an
ERR_METHOD_NOT_IMPLEMENTEDerror.Note that we have plans to implement them in the future, see cloudflare/workerd#3009 for more details.
Most diffs in the PR are due to the formatting fix, the actual changes are l80+
/cc @jasnell