Fix aws-sdk-js-v3 code example for version 3.729.0 or later #19236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGPixel
requested review from
a team,
Oxyjun,
elithrar and
jonesphillip
as code owners
github-actions
bot
added
size/xs
product:r2
CloudPassenger
added a commit
to CloudPassenger/lobe-chat
that referenced
this pull request
Jan 16, 2025
Merged
8 tasks
arvinxx
added a commit
to lobehub/lobe-chat
that referenced
this pull request
Jan 17, 2025
#5479) * 🐛 fix: S3 client integrity check for Cloudflare R2 related issues: cloudflare/cloudflare-docs#19236 aws/aws-sdk-js-v3#6810 * Update index.ts --------- Co-authored-by: Arvin Xu <[email protected]>
gecsp
pushed a commit
to gecsp/lobe-chat
that referenced
this pull request
Jan 22, 2025
lobehub#5479) * 🐛 fix: S3 client integrity check for Cloudflare R2 related issues: cloudflare/cloudflare-docs#19236 aws/aws-sdk-js-v3#6810 * Update index.ts --------- Co-authored-by: Arvin Xu <[email protected]>
Contributor
|
Thanks for opening this PR! As an update: this information has been added to all applicable pages in a separate PR, so I'll close this PR for now. 😄 |
ramu-narasinga
pushed a commit
to ramu-narasinga/lobe-chat
that referenced
this pull request
Feb 17, 2025
lobehub#5479) * 🐛 fix: S3 client integrity check for Cloudflare R2 related issues: cloudflare/cloudflare-docs#19236 aws/aws-sdk-js-v3#6810 * Update index.ts --------- Co-authored-by: Arvin Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The latest release of
@aws-sdk/client-s3(3.729.0) introduced a breaking change with R2. Many commands, such asPutObjectare now failing with error501: NotImplemented: Header 'x-amz-checksum-crc32' with value (***) not implementedbecause AWS is now enforcing checksums.The workaround is to set the
requestChecksumCalculationandresponseChecksumValidationproperties toWHEN_REQUIREDwhen initializing the client.It would be best if Cloudflare could support this new header as there's no telling how long AWS will allow this setting to be disabled.
See aws/aws-sdk-js-v3#6810 for more info.
Documentation checklist