From 96644e0e07dbd4c4b3a68da681a8f2fc32898b00 Mon Sep 17 00:00:00 2001 From: Mike Nomitch Date: Thu, 30 Jan 2025 08:35:13 -0800 Subject: [PATCH] Updates dns docs to not use unimplemented method --- .../2025-01-28-nodejs-compat-improvements.mdx | 5 ++--- src/content/docs/workers/runtime-apis/nodejs/dns.mdx | 7 ++++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/content/changelogs-next/2025-01-28-nodejs-compat-improvements.mdx b/src/content/changelogs-next/2025-01-28-nodejs-compat-improvements.mdx index f59fd452e812a44..6d35bd073a7cb91 100644 --- a/src/content/changelogs-next/2025-01-28-nodejs-compat-improvements.mdx +++ b/src/content/changelogs-next/2025-01-28-nodejs-compat-improvements.mdx @@ -53,10 +53,9 @@ You can use [`node:dns`](https://nodejs.org/api/dns.html) for name resolution vi ```ts -import dns from "node:dns"; +import dns from 'node:dns'; -dns.lookup("example.org", (_err: any, address: string, ipFamily: number) => - console.log(`address: ${address} family: IPv${ipFamily}`)); +let responese = await dns.promises.resolve4('cloudflare.com', 'NS'); ```` diff --git a/src/content/docs/workers/runtime-apis/nodejs/dns.mdx b/src/content/docs/workers/runtime-apis/nodejs/dns.mdx index 53b18f69aa3e884..d41053bcab712e1 100644 --- a/src/content/docs/workers/runtime-apis/nodejs/dns.mdx +++ b/src/content/docs/workers/runtime-apis/nodejs/dns.mdx @@ -12,13 +12,14 @@ You can use [`node:dns`](https://nodejs.org/api/dns.html) for name resolution vi ```ts -import dns from "node:dns"; +import dns from 'node:dns'; -dns.lookup("example.org", (_err: any, address: string, ipFamily: number) => - console.log(`address: ${address} family: IPv${ipFamily}`)); +let responese = await dns.promises.resolve4('cloudflare.com', 'NS'); ``` +All `node:dns` functions are available, except `lookup`, `lookupService`, and `resolve` which throw "Not implemented" errors when called. + :::note DNS requests will execute a subrequest, counts for your [Worker's subrequest limit](/workers/platform/limits/#subrequests).