Skip to content

Conversation

@ToriLindsay
Copy link
Contributor

@ToriLindsay ToriLindsay commented Feb 24, 2025

WIP

Fixes #19653

@github-actions
Copy link
Contributor

Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

@github-actions github-actions bot added product:workers Related to Workers product size/s labels Feb 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for people getting started. Approved pending the C3 template landing and the links being updated.

There is also a class of people who already have React/Vite projects who would like to deploy to Cloudflare. Do we have a format for migrating frameworks to Cloudflare?

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyperlint Review is complete!

Hyperlint Vale Style Guide Review

Reviewed 1 files and found 1 issues.

See the inline comments and suggestions below.

Hyperlint Link Check Review

Reviewed 1 files and found 0 issues.


We are upgrading our reviewer model! Going forward, our model will learn your particular style - which comments you all accept and reject, so that it can further personalize its suggestions.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. It can review, edit, and suggest fixes for your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

@ToriLindsay
Copy link
Contributor Author

ToriLindsay commented Mar 5, 2025

This looks good for people getting started. Approved pending the C3 template landing and the links being updated.

There is also a class of people who already have React/Vite projects who would like to deploy to Cloudflare. Do we have a format for migrating frameworks to Cloudflare?

@petebacondarwin I left you some inline questions. Once those are resolved, will this be ready to merge? (I ask because I see that your template is merged, but the original template this was created for isn't merged, and I'm not sure what the difference is.

To answer your question about migrating existing frameworks. That's a content gap we need to fill in. Is the process essentially the same for each framework guide? If so, we can create a "Migrate your existing project" partial and add it to each guide? If that sounds like the right approach, I think it would make sense to create that as a separate follow-up PR. Let me know. Thanks!
cc: @mikenomitch @nevikashah

@petebacondarwin
Copy link
Contributor

@petebacondarwin I left you some inline questions. Once those are resolved, will this be ready to merge? (I ask because I see that your template is merged, but the original template this was created for isn't merged, and I'm not sure what the difference is.

Yes this docs update looks ready to merge once we resolve those two inline comments.

@ToriLindsay
Copy link
Contributor Author

@petebacondarwin I left you some inline questions. Once those are resolved, will this be ready to merge? (I ask because I see that your template is merged, but the original template this was created for isn't merged, and I'm not sure what the difference is.

Yes this docs update looks ready to merge once we resolve those two inline comments.

@petebacondarwin Updated!

@Maddy-Cloudflare Maddy-Cloudflare marked this pull request as ready for review March 5, 2025 16:53
@Maddy-Cloudflare Maddy-Cloudflare requested review from a team and GregBrimble as code owners March 5, 2025 16:53
@petebacondarwin
Copy link
Contributor

I have a PR up to graduate the Workers C3 template from experimental: cloudflare/workers-sdk#8371
When that lands this PR should be updated to remove the --experimental option and add --platform=workers option.

@ToriLindsay
Copy link
Contributor Author

I have a PR up to graduate the Workers C3 template from experimental: cloudflare/workers-sdk#8371 When that lands this PR should be updated to remove the --experimental option and add --platform=workers option.

@petebacondarwin Just to clarify - I should hold off on merging this until that lands?

@petebacondarwin
Copy link
Contributor

I have a PR up to graduate the Workers C3 template from experimental: cloudflare/workers-sdk#8371 When that lands this PR should be updated to remove the --experimental option and add --platform=workers option.

@petebacondarwin Just to clarify - I should hold off on merging this until that lands?

If it is ready to merge now, you can go ahead. I am going to merge the workers-sdk change now. But it will probably not be released until Tuesday now. So we can have a new PR for then.

@petebacondarwin
Copy link
Contributor

Oh it seems we are going to release the workers-sdk changes today. So let's hold on merging this and fix it up to match the non-experimental C3 template.

@petebacondarwin petebacondarwin enabled auto-merge (squash) March 6, 2025 15:06
@petebacondarwin petebacondarwin merged commit aba60de into production Mar 6, 2025
11 checks passed
@petebacondarwin petebacondarwin deleted the tori/19653-reactjs-framework-guide-for-workers branch March 6, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document how to start with React.js + Vite + Workers

8 participants