From 56400f3b0b8a59fc63d7f120378aba26791245a4 Mon Sep 17 00:00:00 2001 From: James Ross Date: Sat, 1 Mar 2025 22:25:13 +0000 Subject: [PATCH 1/2] chore: tweak grammar of external contributor PR commenet --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 4b26bedd18f37c..642a71e1787d6b 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -29,7 +29,7 @@ jobs: env: GH_TOKEN: ${{ secrets.HOLOPIN_LABELER }} - name: External comment - run: gh pr comment "$NUMBER" --body "Howdy and thanks for contributing to our repo. We review new, external PRs within **2 weeks**. If it's been longer than then without any movement, tag the PR **Assignees** in a comment." + run: gh pr comment "$NUMBER" --body "Howdy and thanks for contributing to our repo. We review new, external PRs within **2 weeks**. If it's been longer than that without any movement, please tag the PR **Assignees** in a comment." if: steps.check_if_contributor_is_external.outputs.is_external == 'true' env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 0158823d32e2d12da7b1789f9959b0b9fc861106 Mon Sep 17 00:00:00 2001 From: Kody Jackson Date: Tue, 4 Mar 2025 15:51:53 -0600 Subject: [PATCH 2/2] Update .github/workflows/pr.yml Co-authored-by: Max Phillips --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 642a71e1787d6b..78612f622d5890 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -29,7 +29,7 @@ jobs: env: GH_TOKEN: ${{ secrets.HOLOPIN_LABELER }} - name: External comment - run: gh pr comment "$NUMBER" --body "Howdy and thanks for contributing to our repo. We review new, external PRs within **2 weeks**. If it's been longer than that without any movement, please tag the PR **Assignees** in a comment." + run: gh pr comment "$NUMBER" --body "Howdy and thanks for contributing to our repo. We review new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment." if: steps.check_if_contributor_is_external.outputs.is_external == 'true' env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}