Skip to content

Remove mentions of Wrangler & Miniflare v2 #20618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2025
Merged

Remove mentions of Wrangler & Miniflare v2 #20618

merged 3 commits into from
Mar 11, 2025

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Mar 7, 2025

Summary

Remove direct mentions of Wrangler & Miniflare v2

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

@github-actions github-actions bot added size/s product:d1 D1: https://developers.cloudflare.com/d1/ product:pages labels Mar 7, 2025
@github-actions github-actions bot added the product:workers Related to Workers product label Mar 7, 2025
@Oxyjun
Copy link
Contributor

Oxyjun commented Mar 10, 2025

Hey @penalosa, the GitHub pipeline is failing because even though we're removed the partial files, the places in the docs where we call that partial file is still present (i.e. they're now calling a deleted file).

I can help remove these references, but I want to check - are we happy to go ahead in removing the warnings completely, instead of rewording, etc?

@penalosa penalosa requested a review from aninibread as a code owner March 10, 2025 17:48
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Mar 10, 2025

PR Change Summary

Removed mentions of Wrangler and Miniflare v2 throughout the documentation to streamline content and avoid confusion.

  • Eliminated direct references to Wrangler v2 in multiple documentation files.
  • Updated descriptions to remove dependencies on Miniflare v2.
  • Clarified the use of D1 databases without specific version mentions.

Modified Files

  • src/content/docs/d1/tutorials/build-a-comments-api/index.mdx
  • src/content/docs/pages/how-to/use-direct-upload-with-continuous-integration.mdx
  • src/content/docs/workers/wrangler/custom-builds.mdx
  • src/content/partials/workers/wrangler-v1-deprecation.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

@penalosa
Copy link
Contributor Author

penalosa commented Mar 10, 2025

I've removed the deprecation partial that should stay, so hopefully this passes CI now!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

Preview URL: https://f054b25c.preview.developers.cloudflare.com
Preview Branch URL: https://penalosa-no-v2.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/d1/tutorials/build-a-comments-api/ https://penalosa-no-v2.preview.developers.cloudflare.com/d1/tutorials/build-a-comments-api/
https://developers.cloudflare.com/pages/how-to/use-direct-upload-with-continuous-integration/ https://penalosa-no-v2.preview.developers.cloudflare.com/pages/how-to/use-direct-upload-with-continuous-integration/
https://developers.cloudflare.com/workers/wrangler/custom-builds/ https://penalosa-no-v2.preview.developers.cloudflare.com/workers/wrangler/custom-builds/

@penalosa penalosa merged commit 36e5ddf into production Mar 11, 2025
10 of 11 checks passed
@penalosa penalosa deleted the penalosa/no-v2 branch March 11, 2025 09:29
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
@penalosa @RebeccaTamachiro
Remove mentions of Wrangler & Miniflare v2 (#20618)
8c77f28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irvinebroque irvinebroque irvinebroque approved these changes

@Oxyjun Oxyjun Oxyjun approved these changes

@ToriLindsay ToriLindsay Awaiting requested review from ToriLindsay

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@mikenomitch mikenomitch Awaiting requested review from mikenomitch mikenomitch is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@elithrar elithrar Awaiting requested review from elithrar elithrar is a code owner

@thomasgauvin thomasgauvin Awaiting requested review from thomasgauvin thomasgauvin is a code owner

@rts-rob rts-rob Awaiting requested review from rts-rob

@vy-ton vy-ton Awaiting requested review from vy-ton vy-ton is a code owner

@aninibread aninibread Awaiting requested review from aninibread aninibread is a code owner

Assignees

@elithrar elithrar

@irvinebroque irvinebroque

@mikenomitch mikenomitch

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@rts-rob rts-rob

@vy-ton vy-ton

@thomasgauvin thomasgauvin

@Oxyjun Oxyjun

@ToriLindsay ToriLindsay

Labels

product:d1 D1: https://developers.cloudflare.com/d1/ product:pages product:workers Related to Workers product size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.