Skip to content

Conversation

@guesty47
Copy link

@guesty47 guesty47 commented Mar 8, 2025

Building via git integration is handled by the wrangler file

Summary

One liner that could have saved me an hour

Documentation checklist

Building via git integration is handled by the wrangler file
@guesty47 guesty47 requested review from a team, ToriLindsay and irvinebroque as code owners March 8, 2025 16:42
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2025

Howdy and thanks for contributing to our repo. We review new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

@github-actions github-actions bot added size/xs product:workers Related to Workers product labels Mar 8, 2025
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Mar 8, 2025

PR Change Summary

Updated configuration documentation to clarify the handling of BADENGINE errors when using Git Integration.

  • Added a note about defining the 'NODE_VERSION' environment variable in the wrangler file for Git Integration builds.
  • Clarified the process for resolving BADENGINE errors related to environment variables.

Modified Files

  • src/content/docs/workers/wrangler/configuration.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

@irvinebroque irvinebroque requested a review from aninibread March 9, 2025 01:50
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. I can imagine it was frustrating trying to find a solution here.

I am not sure that the Wrangler configuration doc is the best place for this update though. This is only an issue for Pages projects being run in the Pages CI system.

It feels like https://developers.cloudflare.com/pages/configuration/build-image/#override-default-versions would be the best place to include the change.

@kodster28
Copy link
Collaborator

Closing this out as it's been sitting for a while without any progress. Feel free to re-open as a new PR though.

@kodster28 kodster28 closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants