diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 78612f622d5890c..067c47ffec9c12a 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -18,27 +18,3 @@ jobs: - uses: ./.github/actions/assign-pr with: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - review_comment: - name: Add review comment - runs-on: ubuntu-latest - steps: - - id: check_if_contributor_is_external - name: Check if contributor is external - run: 'curl --write-out ''%{http_code}'' --silent --output /dev/null -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer ${{ env.GH_TOKEN }}" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/orgs/cloudflare/members/${{ github.event.pull_request.user.login }} | grep -q ''204'' && echo "is_external=false" >> $GITHUB_OUTPUT || echo "is_external=true" >> $GITHUB_OUTPUT' - env: - GH_TOKEN: ${{ secrets.HOLOPIN_LABELER }} - - name: External comment - run: gh pr comment "$NUMBER" --body "Howdy and thanks for contributing to our repo. We review new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment." - if: steps.check_if_contributor_is_external.outputs.is_external == 'true' - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - GH_REPO: ${{ github.repository }} - NUMBER: ${{ github.event.pull_request.number }} - - name: Internal comment - run: gh pr comment "$NUMBER" --body "Howdy and thanks for contributing to our repo. We review internal PRs within **1 week**. If it's something urgent or has been sitting without a comment, start a thread in the *Developer Docs* space internally." - if: steps.check_if_contributor_is_external.outputs.is_external == 'false' - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - GH_REPO: ${{ github.repository }} - NUMBER: ${{ github.event.pull_request.number }} diff --git a/.hyperlint/config.yaml b/.hyperlint/config.yaml index 5ef3576343ec058..529388e6842389c 100644 --- a/.hyperlint/config.yaml +++ b/.hyperlint/config.yaml @@ -1,15 +1,16 @@ content_dir: /src/content -authorized_users: - - dcpena - - kodster28 - - KianNH - - marciocloudflare - - pedrosousa - - ranbel - - RebeccaTamachiro -style_guide: +reviewer: + custom_comment: |- + Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment. + + We review internal PRs within **1 week**. If it's something urgent or has been sitting without a comment, start a thread in the *Developer Docs* space internally. enabled: true -openapi: - enabled: true - urls: - - https://raw.githubusercontent.com/cloudflare/api-schemas/main/openapi.json + external_link_validation: + check_status_upon_review_failure: neutral + summarize_pull_request: + enabled: true + vale_style_guide: + check_status_upon_review_failure: neutral + enabled: true + limit_num_reviews: 2 + limit_num_comments: 7