From 5f4311983c9a63b8b98d0b5efb871832ce7c8ea5 Mon Sep 17 00:00:00 2001 From: kodster28 Date: Mon, 10 Mar 2025 08:25:38 -0500 Subject: [PATCH 1/5] [Hyperlint] Adjust settings --- .hyperlint/config.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.hyperlint/config.yaml b/.hyperlint/config.yaml index 5ef3576343ec05..9f5c081eb57d59 100644 --- a/.hyperlint/config.yaml +++ b/.hyperlint/config.yaml @@ -7,8 +7,12 @@ authorized_users: - pedrosousa - ranbel - RebeccaTamachiro -style_guide: +custom_style_guide: enabled: true + check_status_upon_review_failure: success +reviewer: + limit_num_reviews: 2 + limit_num_comments: 7 openapi: enabled: true urls: From 2479a7875b321994ed707a6f6fee3cd50fac360d Mon Sep 17 00:00:00 2001 From: kodster28 Date: Mon, 10 Mar 2025 08:26:20 -0500 Subject: [PATCH 2/5] Custom review message --- .hyperlint/config.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.hyperlint/config.yaml b/.hyperlint/config.yaml index 9f5c081eb57d59..186c1b51d59098 100644 --- a/.hyperlint/config.yaml +++ b/.hyperlint/config.yaml @@ -13,6 +13,7 @@ custom_style_guide: reviewer: limit_num_reviews: 2 limit_num_comments: 7 + custom_comment: "Howdy and thanks for contributing to our repo. We review new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment.\n\nWe review internal PRs within **1 week**. If it's something urgent or has been sitting without a comment, start a thread in the *Developer Docs* space internally." openapi: enabled: true urls: From 42d4889097c73d2bcc57ce83fcc55bce080ee39e Mon Sep 17 00:00:00 2001 From: kodster28 Date: Mon, 10 Mar 2025 08:26:43 -0500 Subject: [PATCH 3/5] Remove comment from PR check --- .github/workflows/pr.yml | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 78612f622d5890..067c47ffec9c12 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -18,27 +18,3 @@ jobs: - uses: ./.github/actions/assign-pr with: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - review_comment: - name: Add review comment - runs-on: ubuntu-latest - steps: - - id: check_if_contributor_is_external - name: Check if contributor is external - run: 'curl --write-out ''%{http_code}'' --silent --output /dev/null -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer ${{ env.GH_TOKEN }}" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/orgs/cloudflare/members/${{ github.event.pull_request.user.login }} | grep -q ''204'' && echo "is_external=false" >> $GITHUB_OUTPUT || echo "is_external=true" >> $GITHUB_OUTPUT' - env: - GH_TOKEN: ${{ secrets.HOLOPIN_LABELER }} - - name: External comment - run: gh pr comment "$NUMBER" --body "Howdy and thanks for contributing to our repo. We review new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment." - if: steps.check_if_contributor_is_external.outputs.is_external == 'true' - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - GH_REPO: ${{ github.repository }} - NUMBER: ${{ github.event.pull_request.number }} - - name: Internal comment - run: gh pr comment "$NUMBER" --body "Howdy and thanks for contributing to our repo. We review internal PRs within **1 week**. If it's something urgent or has been sitting without a comment, start a thread in the *Developer Docs* space internally." - if: steps.check_if_contributor_is_external.outputs.is_external == 'false' - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - GH_REPO: ${{ github.repository }} - NUMBER: ${{ github.event.pull_request.number }} From a3f36bd3ccfb1361b52ac03a5d2e1472be258a04 Mon Sep 17 00:00:00 2001 From: kodster28 Date: Mon, 10 Mar 2025 14:48:20 -0500 Subject: [PATCH 4/5] Revised --- .hyperlint/config.yaml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/.hyperlint/config.yaml b/.hyperlint/config.yaml index 186c1b51d59098..279a70e9d6e70f 100644 --- a/.hyperlint/config.yaml +++ b/.hyperlint/config.yaml @@ -7,13 +7,21 @@ authorized_users: - pedrosousa - ranbel - RebeccaTamachiro -custom_style_guide: - enabled: true - check_status_upon_review_failure: success reviewer: + custom_comment: |- + Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment. + + We review internal PRs within **1 week**. If it's something urgent or has been sitting without a comment, start a thread in the *Developer Docs* space internally. + enabled: true + external_link_validation: + check_status_upon_review_failure: neutral + summarize_pull_request: + enabled: true + vale_style_guide: + check_status_upon_review_failure: neutral + enabled: true limit_num_reviews: 2 limit_num_comments: 7 - custom_comment: "Howdy and thanks for contributing to our repo. We review new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment.\n\nWe review internal PRs within **1 week**. If it's something urgent or has been sitting without a comment, start a thread in the *Developer Docs* space internally." openapi: enabled: true urls: From 13755251d9928090bbd6d33aa74ea1bd85aec8cc Mon Sep 17 00:00:00 2001 From: kodster28 Date: Tue, 11 Mar 2025 08:25:11 -0500 Subject: [PATCH 5/5] Update --- .hyperlint/config.yaml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.hyperlint/config.yaml b/.hyperlint/config.yaml index 279a70e9d6e70f..529388e6842389 100644 --- a/.hyperlint/config.yaml +++ b/.hyperlint/config.yaml @@ -1,12 +1,4 @@ content_dir: /src/content -authorized_users: - - dcpena - - kodster28 - - KianNH - - marciocloudflare - - pedrosousa - - ranbel - - RebeccaTamachiro reviewer: custom_comment: |- Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment. @@ -22,7 +14,3 @@ reviewer: enabled: true limit_num_reviews: 2 limit_num_comments: 7 -openapi: - enabled: true - urls: - - https://raw.githubusercontent.com/cloudflare/api-schemas/main/openapi.json