-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Updates Astro Framework Guide for deploying on Workers #21114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated the Astro Framework Guide to enhance deployment instructions for Cloudflare Workers.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
Preview URL: https://db442485.preview.developers.cloudflare.com Files with changes (up to 15) |
irvinebroque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do i take an existing Astro project and make it work on Cloudflare?
|
Co-authored-by: Pete Bacon Darwin <[email protected]>
korinne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing docs, thanks @emily-shen !
| --- | ||
|
|
||
| After setting up your project, change your directory by running the following command: | ||
| **Or just deploy** - create a static blog with Astro and deploy it on Cloudflare Workers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Or just deploy** - create a static blog with Astro and deploy it on Cloudflare Workers. | |
| **Or just deploy** - create a static blog with Astro and deploy it on Cloudflare Workers. We'll create a repository, and set up CI/CD and and preview deployments for you, via [Workers Builds](/workers/ci-cd/builds/). |
@korinne @nevikashah @kale-stew - I'm not sure what I'm suggesting is quite right, but directionally — it seems like we have an opportunity to tell people that if they choose this path (here or anywhere else) that they'll get this all setup for them?
Just wondering if people already intuit this or not. Maybe overkill? Your call but just think there is so much you get with going down this path that I'm not quite sure people know is possible otherwise?
irvinebroque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are looking great
* updates framework guide for Astro on Workers * Update src/content/docs/workers/frameworks/framework-guides/astro.mdx Co-authored-by: Pete Bacon Darwin <[email protected]> * simplify introduction * update migration guides * forgot build step * fix headings * get rid of tabs * change wording a bit? * remove aside * fixups * typos and ssr terminology * update bindings copy * assetsignore --------- Co-authored-by: Pete Bacon Darwin <[email protected]> Co-authored-by: emily-shen <[email protected]>
Summary
Documentation checklist