-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Ruleset Engine] Use APIRequest component #21252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruleset Engine] Use APIRequest component #21252
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated the documentation to utilize the APIRequest component for various API interactions related to rulesets, enhancing consistency and clarity.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
| "version": "1", | ||
| "action": "log", | ||
| "expression": "cf.zone.name eq \"example.com\"", | ||
| "last_updated": "2021-03-17T15:42:37.917815Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example output was incorrect (there was repeated content).
| "description": "Executes a managed ruleset.", | ||
| "kind": "zone", | ||
| "version": "3", | ||
| "version": "<RULESET_VERSION>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: Value depends on what was requested.
| "description": "Managed ruleset created by Cloudflare", | ||
| "kind": "managed", | ||
| "version": "4", | ||
| "version": "2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed: Should match the requested ruleset version.
Co-authored-by: Rebecca Tamachiro <[email protected]>
--------- Co-authored-by: Rebecca Tamachiro <[email protected]>
Summary
Partially addresses PCX-16352.