Skip to content

Conversation

@RebeccaTamachiro
Copy link
Contributor

Summary

PCX-16431

@RebeccaTamachiro RebeccaTamachiro requested a review from a team as a code owner April 1, 2025 09:15
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 1, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated API documentation links for DNS view actions to reflect changes in endpoint paths.

  • Corrected endpoint links for creating, deleting, updating, and retrieving DNS views to include 'account' in the path.
  • Ensured consistency in documentation regarding DNS view actions across multiple files.

Modified Files

  • src/content/docs/dns/internal-dns/dns-views.mdx
  • src/content/docs/dns/internal-dns/get-started.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions github-actions bot added size/s product:dns Issues or PRs related to DNS labels Apr 1, 2025
@RebeccaTamachiro RebeccaTamachiro enabled auto-merge (squash) April 1, 2025 09:29
- [List DNS views](/api/resources/dns/subresources/settings/subresources/views/methods/list/) (`GET`)
- [Update a DNS view](/api/resources/dns/subresources/settings/subresources/account/subresources/views/methods/edit/) (`PATCH`)
- [Get view details](/api/resources/dns/subresources/settings/subresources/account/subresources/views/methods/get/) (`GET`)
- [List DNS views](/api/resources/dns/subresources/settings/subresources/account/subresources/views/methods/list/) (`GET`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should we use the names we have in the API reference?

  • Update Internal DNS View
  • DNS Internal View Details
  • List Internal DNS Views

@RebeccaTamachiro RebeccaTamachiro merged commit 4bdf47a into production Apr 1, 2025
11 checks passed
@RebeccaTamachiro RebeccaTamachiro deleted the rebecca/internal-dns-api-links-check branch April 1, 2025 09:38
RebeccaTamachiro added a commit that referenced this pull request Apr 21, 2025
* Fix URL for view creation

* Fix URLs for other view actions

* Fix API link for Update DNS zone action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:dns Issues or PRs related to DNS size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants