Skip to content

[CF1] windows application check #21378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

[CF1] windows application check #21378

merged 1 commit into from
Apr 4, 2025

Conversation

@deadlypants1973
Copy link
Contributor

@deadlypants1973 deadlypants1973 commented Apr 3, 2025

Summary

PCX-9840
closes #15571

Screenshots (optional)

Screenshot 2025-04-03 at 18 45 00

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@deadlypants1973 deadlypants1973 requested review from a team, kennyj42 and ranbel as code owners April 3, 2025 17:48
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 3, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Updated the application check documentation for Windows to include new commands for verifying active processes.

  • Added instructions for checking active processes on Windows using PowerShell.
  • Specified that the application path must appear in the output for the check to pass.

Modified Files

  • src/content/docs/cloudflare-one/identity/devices/warp-client-checks/application-check.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Preview URL: https://8528aa05.preview.developers.cloudflare.com
Preview Branch URL: https://kate-fixes-windowsapp.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/cloudflare-one/identity/devices/warp-client-checks/application-check/ https://kate-fixes-windowsapp.preview.developers.cloudflare.com/cloudflare-one/identity/devices/warp-client-checks/application-check/

@deadlypants1973
Copy link
Contributor Author

deadlypants1973 commented Apr 4, 2025

approved by Shrey on technical side

@deadlypants1973 deadlypants1973 merged commit f066d7a into production Apr 4, 2025
12 checks passed
@deadlypants1973 deadlypants1973 deleted the kate/fixes-windowsapp branch April 4, 2025 10:52
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
@deadlypants1973 @RebeccaTamachiro
[CF1] windows application check (#21378)
f37d685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kodster28 kodster28 kodster28 approved these changes

@kennyj42 kennyj42 Awaiting requested review from kennyj42 kennyj42 is a code owner

@ranbel ranbel Awaiting requested review from ranbel ranbel is a code owner

Assignees

@kennyj42 kennyj42

@ranbel ranbel

Labels

product:cloudflare-one size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Windows in "How WARP checks for an application"

4 participants

@deadlypants1973 @kodster28 @kennyj42 @ranbel