Skip to content

[CF1] brave browser and rbi settings #21596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

[CF1] brave browser and rbi settings #21596

merged 1 commit into from
Apr 14, 2025

Conversation

@deadlypants1973
Copy link
Contributor

@deadlypants1973 deadlypants1973 commented Apr 10, 2025

Summary

PCX-16561

Screenshots (optional)

Screenshot 2025-04-10 at 12 37 47

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@deadlypants1973 deadlypants1973 requested review from a team, maxvp and ranbel as code owners April 10, 2025 11:38
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 10, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Updated documentation to include Brave browser settings affecting Cloudflare RBI functionality.

  • Added information about Brave's WebRTC IP Handling Policy and its impact on RBI loading.
  • Provided instructions for configuring Brave settings to ensure proper RBI functionality.

Modified Files

  • src/content/docs/cloudflare-one/policies/browser-isolation/known-limitations.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

Preview URL: https://d5134d90.preview.developers.cloudflare.com
Preview Branch URL: https://kate-fixes-brave-rbi.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/cloudflare-one/policies/browser-isolation/known-limitations/ https://kate-fixes-brave-rbi.preview.developers.cloudflare.com/cloudflare-one/policies/browser-isolation/known-limitations/

cdisher
cdisher approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@cdisher cdisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadlypants1973 deadlypants1973 merged commit b77349b into production Apr 14, 2025
12 checks passed
@deadlypants1973 deadlypants1973 deleted the kate/fixes-brave-rbi branch April 14, 2025 13:28
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
@deadlypants1973 @RebeccaTamachiro
[CF1] brave browser and rbi settings (#21596)
c365d0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oxyjun Oxyjun Oxyjun approved these changes

@maxvp maxvp Awaiting requested review from maxvp

@ranbel ranbel Awaiting requested review from ranbel ranbel is a code owner

+1 more reviewer

@cdisher cdisher cdisher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maxvp maxvp

@ranbel ranbel

Labels

product:cloudflare-one size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deadlypants1973 @cdisher @Oxyjun @maxvp @ranbel