Skip to content

Conversation

@grocco
Copy link
Contributor

@grocco grocco commented Apr 18, 2025

Summary

One of the previous rules of Workflows suggests not using non-unique IDs such as user IDs, and here they are used (and not tagged as bad).

Suggestion: use order objects instead (order ids might be "more" unique).

Documentation checklist

use unique ids as suggested by previous rule
@grocco grocco requested review from a team, celso and elithrar as code owners April 18, 2025 15:43
@github-actions github-actions bot added product:workflows Workflows: https://developers.cloudflare.com/workflows/ size/xs labels Apr 18, 2025
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 18, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated the examples in the rules of workflows documentation to use unique order IDs instead of non-unique user IDs.

  • Replaced non-unique user IDs with unique order IDs in examples.
  • Improved clarity on the use of unique identifiers in workflows.

Modified Files

  • src/content/docs/workflows/build/rules-of-workflows.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@Oxyjun Oxyjun enabled auto-merge (squash) August 12, 2025 10:36
@Oxyjun Oxyjun merged commit 5446c04 into cloudflare:production Aug 12, 2025
2 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Aug 12, 2025
@holopin-bot
Copy link

holopin-bot bot commented Aug 12, 2025

Congratulations @grocco, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cme8f51js098307l2k0vzg7cl

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

thomasgauvin pushed a commit that referenced this pull request Aug 15, 2025
* Update rules-of-workflows.mdx

use unique ids as suggested by previous rule

* Triggering GH compiles

* Undoing redundant change

* Update src/content/docs/workflows/build/rules-of-workflows.mdx

---------

Co-authored-by: Jun Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes a docs contribution, big or small product:workflows Workflows: https://developers.cloudflare.com/workflows/ size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants