-
Notifications
You must be signed in to change notification settings - Fork 10k
[Docs Site] use unique IDs as example in rules-of-workflows.mdx #21816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
use unique ids as suggested by previous rule
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated the examples in the rules of workflows documentation to use unique order IDs instead of non-unique user IDs.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
Congratulations @grocco, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cme8f51js098307l2k0vzg7cl This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
* Update rules-of-workflows.mdx use unique ids as suggested by previous rule * Triggering GH compiles * Undoing redundant change * Update src/content/docs/workflows/build/rules-of-workflows.mdx --------- Co-authored-by: Jun Lee <[email protected]>
Summary
One of the previous rules of Workflows suggests not using non-unique IDs such as user IDs, and here they are used (and not tagged as bad).
Suggestion: use order objects instead (order ids might be "more" unique).
Documentation checklist