Skip to content

Update support of run_worker_first #21974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update support of run_worker_first #21974

wants to merge 1 commit into from
+2 −4

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Apr 25, 2025

Summary

Small docs update to Vite Plugin

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes. N/A
  • Files which have changed name or location have been allocated redirects. N/A

@github-actions github-actions bot added the product:workers Related to Workers product label Apr 25, 2025
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 25, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Updated documentation to reflect support for the 'run_worker_first' feature in the Vite Plugin.

  • Clarified that 'run_worker_first' is now supported during build, preview, and deploy time.
  • Updated Wrangler config instructions to include 'run_worker_first' option.

Modified Files

  • src/content/docs/workers/vite-plugin/reference/static-assets.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@petebacondarwin petebacondarwin mentioned this pull request Apr 25, 2025
Merged
12 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Preview URL: https://04438257.preview.developers.cloudflare.com
Preview Branch URL: https://pbd-vite-plugin-run-worker-first.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers/vite-plugin/reference/static-assets/ https://pbd-vite-plugin-run-worker-first.preview.developers.cloudflare.com/workers/vite-plugin/reference/static-assets/

@jamesopstad
Copy link
Contributor

jamesopstad commented Apr 25, 2025

I don't think we should be documenting this at this stage. _headers and _redirects make sense as build time only but run_worker_first doesn't as the behaviour in dev would be very different. I mentioned this in #20481 (comment) and was planning on adding a warning if run_worker_first is enabled.

kodster28
kodster28 approved these changes May 28, 2025
View reviewed changes
src/content/docs/workers/vite-plugin/reference/static-assets.mdx
:::note
The Cloudflare Vite plugin does not support [run_worker_first](/workers/static-assets/binding/#run_worker_first).
:::
Running the Worker ahead of asset handling [run_worker_first](/workers/static-assets/binding/#run_worker_first) is supported at build, preview and deploy time by adding `"run_worker_first" = true` to your Wrangler config.
Copy link
Collaborator

@kodster28 kodster28 May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Running the Worker ahead of asset handling [run_worker_first](/workers/static-assets/binding/#run_worker_first) is supported at build, preview and deploy time by adding `"run_worker_first" = true` to your Wrangler config.
Running the Worker ahead of asset handling [run_worker_first](/workers/static-assets/binding/#run_worker_first) is supported at build, preview, and deploy time by adding `"run_worker_first" = true` to your Wrangler config.

jamesopstad
jamesopstad requested changes May 29, 2025
View reviewed changes
Copy link
Contributor

@jamesopstad jamesopstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to put the breaks on this PR as we have a better solution just around the corner and it would be confusing to change the existing documentation ahead of that.

@ToriLindsay ToriLindsay removed their request for review June 6, 2025 11:33
@ToriLindsay ToriLindsay assigned kodster28 and unassigned ToriLindsay Jun 6, 2025
@jamesopstad
Copy link
Contributor

jamesopstad commented Jul 17, 2025

Closing this as run_worker_first is now supported in the Vite plugin and the docs were updated in #23008.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesopstad jamesopstad jamesopstad requested changes

@kodster28 kodster28 kodster28 approved these changes

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

@mikenomitch mikenomitch Awaiting requested review from mikenomitch mikenomitch is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

Assignees

@irvinebroque irvinebroque

@mikenomitch mikenomitch

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@kodster28 kodster28

Labels

product:workers Related to Workers product size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@petebacondarwin @jamesopstad @kodster28 @irvinebroque @mikenomitch @GregBrimble @WalshyDev @ToriLindsay