Skip to content

gateway terraform doc changes #22286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2025
Merged

gateway terraform doc changes #22286

merged 2 commits into from
May 8, 2025

Conversation

@rexscaria
Copy link
Contributor

@rexscaria rexscaria commented May 8, 2025

typo fixes

@rexscaria rexscaria requested review from a team and maxvp as code owners May 8, 2025 00:14
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented May 8, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Corrected typos and improved clarity in the Terraform documentation for Gateway policies.

  • Updated terminology from 'numeric UUID' to 'numeric ID' for clarity.
  • Improved wording for managing the order of execution of Gateway policies in Terraform.
  • Clarified instructions for avoiding precedence calculation errors during policy reordering.

Modified Files

  • src/content/docs/cloudflare-one/policies/gateway/application-app-types.mdx
  • src/content/docs/cloudflare-one/policies/gateway/domain-categories.mdx
  • src/content/partials/cloudflare-one/gateway/order-of-enforcement.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

rexscaria
rexscaria commented May 8, 2025
View reviewed changes
src/content/docs/cloudflare-one/policies/gateway/application-app-types.mdx

Terraform users can retrieve the app types list with the `cloudflare_zero_trust_gateway_app_types_list` data source. This allows you to create Gateway policies with the application's name rather than its numeric UUID. For example:
Terraform users can retrieve the app types list with the `cloudflare_zero_trust_gateway_app_types_list` data source. This allows you to create Gateway policies with the application's name rather than its numeric ID. For example:

Copy link
Contributor Author

@rexscaria rexscaria May 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the category id and app ids are integer ids, not uuids

@rexscaria rexscaria force-pushed the rex/terraform-typo-fixes branch from 56b9a69 to 29aa63a Compare May 8, 2025 00:16
@rexscaria rexscaria force-pushed the rex/terraform-typo-fixes branch from 29aa63a to e3cbfa8 Compare May 8, 2025 00:22
maxvp
maxvp reviewed May 8, 2025
View reviewed changes
@maxvp maxvp enabled auto-merge (squash) May 8, 2025 15:51
@maxvp maxvp merged commit 3d42dfa into cloudflare:production May 8, 2025
6 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label May 8, 2025
@holopin-bot
Copy link

holopin-bot bot commented May 8, 2025

Congratulations @rexscaria, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmafk3u0q73760djipso5ivdw

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Maddy-Cloudflare pushed a commit that referenced this pull request May 9, 2025
@rexscaria @maxvp @Maddy-Cloudflare
gateway terraform doc changes (#22286)
0c64cc0 
Co-authored-by: Rex Scaria <[email protected]>
Co-authored-by: Max Phillips <[email protected]>
daisyfaithauma pushed a commit that referenced this pull request May 13, 2025
@rexscaria @maxvp @daisyfaithauma
gateway terraform doc changes (#22286)
9fc9ba9 
Co-authored-by: Rex Scaria <[email protected]>
Co-authored-by: Max Phillips <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxvp maxvp maxvp approved these changes

Assignees

@maxvp maxvp

Labels

contribution [Holopin] Recognizes a docs contribution, big or small product:cloudflare-one size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rexscaria @maxvp @workers-devprod