Skip to content

Added additional captive portal check domains #22323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Added additional captive portal check domains #22323

merged 1 commit into from
May 9, 2025

Conversation

@aw-cf
Copy link
Contributor

@aw-cf aw-cf commented May 9, 2025

Summary

Added additional domains used to check for Captive Portals

Documentation checklist

@aw-cf aw-cf requested review from a team and ranbel as code owners May 9, 2025 09:55
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented May 9, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Added additional domains for captive portal checks to enhance connectivity verification.

  • Included new domains for captive portal checks: www.msftconnecttest.com, captive.apple.com, and connectivitycheck.gstatic.com.
  • Updated documentation to reflect the changes in the captive portal check domains.

Modified Files

  • src/content/docs/cloudflare-one/connections/connect-devices/warp/deployment/firewall.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@ranbel ranbel enabled auto-merge (squash) May 9, 2025 16:21
@ranbel ranbel merged commit dbf4380 into cloudflare:production May 9, 2025
7 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label May 9, 2025
@holopin-bot
Copy link

holopin-bot bot commented May 9, 2025

Congratulations @aw-cf, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmah0ltl811920djuj18y5irp

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

daisyfaithauma pushed a commit that referenced this pull request May 13, 2025
@aw-cf @daisyfaithauma
Added additional captive portal check domains (#22323)
d22f7b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranbel ranbel ranbel approved these changes

Assignees

@ranbel ranbel

Labels

contribution [Holopin] Recognizes a docs contribution, big or small product:cloudflare-one size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aw-cf @ranbel @workers-devprod