[Docs Site] Add tags filter to /search/ #22832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
GregBrimble,
WalshyDev,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
github-actions
bot
assigned
GregBrimble,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare and
maxvp
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://c4a2f2c4.preview.developers.cloudflare.com |
kodster28
approved these changes
Jun 2, 2025
Collaborator
There was a problem hiding this comment.
Is there a way to also sync the URL query params with the entered search term?
Maybe this is a future ask since it's like this in the current state too... but it feels more out of place with the tags / products getting appended to your current URL.
So you'd get something like, /search/?q=test&tags=Hono? It respects this logic when you load the page, but the URL doesn't update when you update the search term.
sdnts
pushed a commit
to sdnts/cloudflare-docs
that referenced
this pull request
Jul 24, 2025
* [Docs Site] Add tags filter to /search/ * sync query too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add tags filter to /search/
Fixes the "update URL with params" logic to remove params when all refinements are unticked and support multiple params to be set at once now that we have multiple filters.