[CF1] CF1 docs survey #22904
Merged
[CF1] CF1 docs survey #22904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlypants1973
requested review from
a team,
kennyj42,
maxvp and
ranbel
as code owners
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (6)
- src/content/docs/cloudflare-one/identity/idp-integration/index.mdx (8-8) The component is currently rendered at the very top of the page. If this is not intentional, consider moving it to a more appropriate location or adding conditional logic to control its visibility.
- src/content/docs/cloudflare-one/policies/browser-isolation/index.mdx (16-18) The informational note about plan availability has been moved below the introductory content. Consider whether it should remain at the top of the page to ensure users are immediately aware of plan requirements.
- src/content/docs/cloudflare-one/identity/index.mdx (8-8) The import statement now ends with a semicolon, which is inconsistent with the previous style. Consider removing the semicolon for consistency.
- src/content/docs/cloudflare-one/changelog/gateway.mdx (12-12) Consider adding a comment explaining the purpose of `` to improve maintainability and clarity for future contributors.
- src/content/docs/cloudflare-one/changelog/access.mdx (12-12) Consider adding a comment above the `` line to explain what this component does and what the 'survey' file contains. This will help future maintainers understand the intent behind this addition.
- src/content/docs/cloudflare-one/changelog/dlp.mdx (12-12) Consider adding a comment explaining the purpose of rendering the survey here, to provide context for future maintainers.
💡 To request another review, post a new comment with "/windsurf-review".
| import { DirectoryListing } from "~/components" | ||
| import { DirectoryListing, Render } from "~/components"; | ||
|
|
||
| <Render file="survey" /> |
Contributor
There was a problem hiding this comment.
The component is added at the top of the page. Ensure this does not disrupt the main content flow or accessibility. If this is a temporary addition, consider adding a comment for future maintainers.
|
|
||
| import { Render } from "~/components"; | ||
|
|
||
| <Render file="survey" /> |
Contributor
There was a problem hiding this comment.
The component is rendered at the very top of the page, before any introductory content. Please confirm that this placement is intentional and does not negatively impact the user experience. If the survey is not critical to see before the guide, consider moving it to the end or making its display conditional.
| import { Glossary } from "~/components" | ||
| import { Glossary, Render } from "~/components"; | ||
|
|
||
| <Render file="survey" /> |
Contributor
There was a problem hiding this comment.
The addition of <Render file="survey" /> at the top of the page may be unclear to users. Consider adding a brief comment or section header to explain the purpose of the survey and why it appears here.
Contributor
patriciasantaana
approved these changes
Jun 4, 2025
sdnts
pushed a commit
to sdnts/cloudflare-docs
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PCX-17405
Screenshots (optional)
Documentation checklist