-
Notifications
You must be signed in to change notification settings - Fork 10.1k
update integrations docs #22966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update integrations docs #22966
Conversation
|
This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:
|
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated the integrations documentation for databases and observability, enhancing clarity and organization.
Modified Files
Added Files
Renamed Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments (1)
-
src/content/docs/workers/databases/third-party-integrations/index.mdx (16-20)
There's an unnecessary empty line in the note block that should be removed for better formatting.
:::note[Making multiple round trip calls to a centralized database from a Worker?] If your Worker is making multiple round trip calls to a centralized database, your Worker may be a good fit for Smart Placement. Smart Placement speeds up applications by automatically running your Worker closer to your back-end infrastructure rather than the end user. Learn more about [how Smart Placement works](/workers/configuration/smart-placement/). :::
💡 To request another review, post a new comment with "/windsurf-review".
| description: Connect to third-party databases such as Supabase, | ||
| Turso and PlanetScale) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a syntax error in the description field. The closing parenthesis at the end doesn't have a matching opening parenthesis.
| description: Connect to third-party databases such as Supabase, | |
| Turso and PlanetScale) | |
| description: Connect to third-party databases such as Supabase, | |
| Turso and PlanetScale |
| ```ts | ||
| export default { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code example references XataClient but doesn't include the import statement. Consider adding the import at the top of the code example:
| ```ts | |
| export default { | |
| ```ts | |
| import { XataClient } from '@xata.io/client'; | |
| export default { |
| ```ts | ||
| export default { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code example uses ExportedHandler<Env> and references env with typed properties, but doesn't define the Env interface. Consider adding the type definition:
| ```ts | |
| export default { | |
| ```ts | |
| import { XataClient } from '@xata.io/client'; | |
| interface Env { | |
| XATA_API_KEY: string; | |
| XATA_BRANCH: string; | |
| XATA_DATABASE_URL: string; | |
| } | |
| export default { |
irvinebroque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
update db/observability integrations docs
Documentation checklist