Skip to content

[ZT] ICMP command updates #23409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 3, 2025
Merged

[ZT] ICMP command updates #23409

merged 5 commits into from
Jul 3, 2025

Conversation

@ranbel
Copy link
Contributor

@ranbel ranbel commented Jul 2, 2025

PCX-17791

@ranbel ranbel requested a review from a team as a code owner July 2, 2025 21:20
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Jul 2, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Updated ICMP command instructions for better clarity and detail.

  • Enhanced instructions for ensuring the correct Group ID for ICMP usage with cloudflared.
  • Added steps to find the user running cloudflared and their Group ID.
  • Included instructions for making ICMP configuration changes persistent across reboots.

Modified Files

  • src/content/docs/cloudflare-one/connections/connect-networks/troubleshoot-tunnels/common-errors.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025 •
edited
Loading

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/cloudflare-one/connections/connect-networks/ @ranbel, @cloudflare/pcx-technical-writing
/src/content/docs/cloudflare-one/policies/gateway/ @maxvp, @cloudflare/pcx-technical-writing
* @cloudflare/pcx-technical-writing

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025 •
edited
Loading

Preview URL: https://30e16695.preview.developers.cloudflare.com
Preview Branch URL: https://ranbel-icmp-updates.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/cloudflare-one/policies/gateway/proxy/ https://ranbel-icmp-updates.preview.developers.cloudflare.com/cloudflare-one/policies/gateway/proxy/
https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/troubleshoot-tunnels/common-errors/ https://ranbel-icmp-updates.preview.developers.cloudflare.com/cloudflare-one/connections/connect-networks/troubleshoot-tunnels/common-errors/

@ranbel ranbel requested a review from maxvp as a code owner July 3, 2025 19:39
@github-actions github-actions bot added size/m and removed size/s labels Jul 3, 2025
ranbel
ranbel commented Jul 3, 2025
View reviewed changes
@ranbel ranbel merged commit 9b3a715 into production Jul 3, 2025
11 checks passed
@ranbel ranbel deleted the ranbel/icmp-updates branch July 3, 2025 20:53
sdnts pushed a commit to sdnts/cloudflare-docs that referenced this pull request Jul 24, 2025
@ranbel @sdnts
[ZT] ICMP command updates (cloudflare#23409)
d7b7d61 
* refine ICMP commands

* add step #

* Update src/content/docs/cloudflare-one/connections/connect-networks/troubleshoot-tunnels/common-errors.mdx

* move instructions to Proxy page

* Update src/content/docs/cloudflare-one/policies/gateway/proxy.mdx
thomasgauvin pushed a commit that referenced this pull request Aug 15, 2025
@ranbel @thomasgauvin
[ZT] ICMP command updates (#23409)
c7bdc35 
* refine ICMP commands

* add step #

* Update src/content/docs/cloudflare-one/connections/connect-networks/troubleshoot-tunnels/common-errors.mdx

* move instructions to Proxy page

* Update src/content/docs/cloudflare-one/policies/gateway/proxy.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patriciasantaana patriciasantaana patriciasantaana approved these changes

@maxvp maxvp Awaiting requested review from maxvp

Assignees

No one assigned

Labels

product:cloudflare-one size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ranbel @patriciasantaana