Skip to content

Add node:http and node:https modules #23481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 17, 2025
Merged

Add node:http and node:https modules #23481

merged 8 commits into from
Jul 17, 2025

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jul 7, 2025 •
edited
Loading

Summary

  • Adds node:http and node:https modules

Required by cloudflare/workerd#4456

@github-actions github-actions bot added the product:workers Related to Workers product label Jul 7, 2025
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Jul 7, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Added support for node:http and node:https modules in the documentation, enhancing the Node.js API coverage.

  • Updated Node.js to the latest LTS version (v22)
  • Introduced documentation for node:http and node:https modules
  • Fixed formatting errors across the documentation

Modified Files

  • src/content/docs/workers/runtime-apis/nodejs/url.mdx

Added Files

  • src/content/docs/workers/runtime-apis/nodejs/http.mdx
  • src/content/docs/workers/runtime-apis/nodejs/https.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025 •
edited
Loading

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/workers/ @cloudflare/workers-docs, @GregBrimble, @irvinebroque, @mikenomitch, @korinne, @WalshyDev, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing, @kodster28, @cloudflare/wrangler, @cloudflare/workers-runtime-1, @cloudflare/wrangler

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025 •
edited
Loading

Preview URL: https://51981194.preview.developers.cloudflare.com
Preview Branch URL: https://yagiz-update-nodejs.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers/runtime-apis/nodejs/http/ https://yagiz-update-nodejs.preview.developers.cloudflare.com/workers/runtime-apis/nodejs/http/
https://developers.cloudflare.com/workers/runtime-apis/nodejs/https/ https://yagiz-update-nodejs.preview.developers.cloudflare.com/workers/runtime-apis/nodejs/https/

@vicb vicb mentioned this pull request Jul 7, 2025
Merged
@vicb
Copy link
Contributor

vicb commented Jul 7, 2025

Thanks @anonrig Could you please add details about Agents?

@anonrig
Copy link
Member Author

anonrig commented Jul 7, 2025 •
edited
Loading

Thanks @anonrig Could you please add details about Agents?

@vicb Agent acts as a stub. It's not intended for usage, and not yet fully implemented.

jasnell
jasnell reviewed Jul 7, 2025
View reviewed changes
jasnell
jasnell reviewed Jul 7, 2025
View reviewed changes
@anonrig anonrig force-pushed the yagiz/update-nodejs branch from a13d4fd to 6ddc2a0 Compare July 16, 2025 15:11
jasnell
jasnell reviewed Jul 16, 2025
View reviewed changes
jasnell
jasnell approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few remaining nits but also happy to make improvements incrementally

mikenomitch
mikenomitch reviewed Jul 16, 2025
View reviewed changes
mikenomitch
mikenomitch reviewed Jul 16, 2025
View reviewed changes
dario-piotrowicz
dario-piotrowicz approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just left a few small comments 🙂

jasnell
jasnell reviewed Jul 17, 2025
View reviewed changes
jasnell
jasnell reviewed Jul 17, 2025
View reviewed changes
src/content/docs/workers/runtime-apis/nodejs/http.mdx
});
```

## request
Copy link
Contributor

@jasnell jasnell Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a comment somewhere that appears to have been marked resolved about how these should include links to the relevant node.js docs for these methods. I still think we should include those links.

Copy link
Member Author

@anonrig anonrig Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the header should be a link to node.js docs? Can you be specific?

Copy link
Member Author

@anonrig anonrig Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell is the current state sufficient?

jasnell
jasnell reviewed Jul 17, 2025
View reviewed changes
jasnell
jasnell reviewed Jul 17, 2025
View reviewed changes
jasnell
jasnell reviewed Jul 17, 2025
View reviewed changes
jasnell
jasnell reviewed Jul 17, 2025
View reviewed changes
jasnell
jasnell reviewed Jul 17, 2025
View reviewed changes
jasnell
jasnell reviewed Jul 17, 2025
View reviewed changes
jasnell
jasnell reviewed Jul 17, 2025
View reviewed changes
@anonrig anonrig force-pushed the yagiz/update-nodejs branch from 3d014d9 to bc74bec Compare July 17, 2025 19:18
@anonrig anonrig force-pushed the yagiz/update-nodejs branch from 4434ec0 to 5198119 Compare July 17, 2025 19:22
jasnell
jasnell approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make further improvements in follow up

@anonrig anonrig merged commit fae7c6f into production Jul 17, 2025
11 checks passed
@anonrig anonrig deleted the yagiz/update-nodejs branch July 17, 2025 20:31
sdnts pushed a commit to sdnts/cloudflare-docs that referenced this pull request Jul 24, 2025
@anonrig @sdnts
Add node:http and node:https modules (cloudflare#23481)
fcd6a9a
thomasgauvin pushed a commit that referenced this pull request Aug 15, 2025
@anonrig @thomasgauvin
Add node:http and node:https modules (#23481)
3587695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikenomitch mikenomitch mikenomitch left review comments

@jasnell jasnell jasnell approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

@korinne korinne Awaiting requested review from korinne korinne is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@kodster28 kodster28 Awaiting requested review from kodster28 kodster28 is a code owner

@danlapid danlapid Awaiting requested review from danlapid

@vicb vicb Awaiting requested review from vicb

Assignees

@pedrosousa pedrosousa

@irvinebroque irvinebroque

@mikenomitch mikenomitch

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@kodster28 kodster28

@korinne korinne

@dcpena dcpena

@haleycode haleycode

@patriciasantaana patriciasantaana

Labels

product:workers Related to Workers product size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.