Skip to content

Conversation

@RebeccaTamachiro
Copy link
Contributor

Summary

PCX-11801

@RebeccaTamachiro RebeccaTamachiro requested a review from a team as a code owner July 8, 2025 10:17
@github-actions github-actions bot added product:dns Issues or PRs related to DNS size/s labels Jul 8, 2025
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Jul 8, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Enhanced documentation for advanced nameservers in Foundation DNS, highlighting differences from standard nameservers.

  • Updated caution note to a more informative note regarding advanced nameservers.
  • Added a section outlining key differences between standard and advanced nameservers.
  • Included an example of DNS management for clarity on record handling.

Modified Files

  • src/content/docs/dns/foundation-dns/advanced-nameservers.mdx
  • src/content/docs/dns/foundation-dns/setup.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/dns/ @RebeccaTamachiro, @cloudflare/pcx-technical-writing
* @cloudflare/pcx-technical-writing

@github-actions
Copy link
Contributor

This PR requires additional review attention because it affects the following areas:

Partials

This PR updates partial files, which are pieces of content used across multiple files in our Render component.

| A | www | `192.0.2.1` |
</Example>

In this example, the TXT record and the A record for `www.example.com` will not be served.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still using monospace for DNS record types? (e.g. TXT, A, AAAA, etc.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added an exception for cases where there are several inline occurrences in a roll or for hyperlinks (since the style would make it look like two separate links). This was following a team critique a while ago.

@RebeccaTamachiro RebeccaTamachiro enabled auto-merge (squash) August 1, 2025 07:29
@RebeccaTamachiro RebeccaTamachiro merged commit e4be388 into production Aug 1, 2025
8 checks passed
@RebeccaTamachiro RebeccaTamachiro deleted the rebecca/dns-advanced-ns-behavior branch August 1, 2025 07:41
thomasgauvin pushed a commit that referenced this pull request Aug 15, 2025
* Introduce new limitations section for advanced NS

* Expand to more general considerations and move to setup.mdx

* Text review and add example DNS table for delegation

* Re-add note on Advanced NS vs Custom NS to concept page

* Use specific header for more emphasis and better linking

* Nest DNSSEC keys under Advanced NS in Foundation DNS features

* Add note on advanced ns vs custom in account-custom-nameservers

* Further clarify advanced-vs-custom NS and align with UI messaging

* Revert "Nest DNSSEC keys under Advanced NS in Foundation DNS features"

This reverts commit 459ff3b.

* Replace 'zone' by 'account' in features list

* Create dedicated page explaining Foundation DNSSEC keys

* Add clarification on how to get unique DNSSEC keys

* Apply suggestions from code review

Co-authored-by: Max Phillips <[email protected]>

---------

Co-authored-by: Max Phillips <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:dns Issues or PRs related to DNS size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants