-
Notifications
You must be signed in to change notification settings - Fork 10k
Rename to cf-requirements and add pywrangler section. #23517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryRenamed requirements file and introduced a new section on pywrangler for managing Python packages in Workers.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
9f68aaf to
c06e0b2
Compare
| 1. Wrangler uploads your Python code and your `requirements.txt` file to the Workers API. | ||
| 2. Cloudflare sends your Python code, and your `requirements.txt` file to the Workers runtime to be validated. | ||
| 3. Cloudflare creates a new v8 isolate for your Worker, and automatically injects Pyodide plus any packages you’ve specified in your `requirements.txt` file. | ||
| 1. Wrangler uploads your Python code and your `cf-requirements.txt` file to the Workers API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want the cf-requirements references without any other context for them? Prob not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed references to it, though this section is specifically about how built-in packages are handled. Should I just remove this section, for now at least?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep it in for now, we can remove it later in a separate PR if needed.
c06e0b2 to
cc9c703
Compare
Summary
Updated the Python docs to refer to cf-requirements.txt instead of requirements.txt and added a new section about pywrangler to point people to it instead of the old Built-in package pathway.
Documentation checklist