[Workers] Fix URL Matching Usage in custom_headers.mdx Example
#23541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous example for matching `workers.dev` URLs under "Prevent your workers.dev URLs showing in search results" incorrectly used two splats, i.e. `*`, when only one splat can be used at maximum. This commit updates the example to use a single splat wildcard with a placeholder pattern that correctly matches both `workers.dev` URLs and Preview URLs.
sibi361
requested review from
a team,
GregBrimble,
WalshyDev,
irvinebroque,
kodster28 and
mikenomitch
as code owners
github-actions
bot
assigned
GregBrimble,
irvinebroque,
kodster28,
mikenomitch and
WalshyDev
petebacondarwin
approved these changes
Aug 11, 2025
kodster28
reviewed
Aug 11, 2025
kodster28
reviewed
Aug 11, 2025
kodster28
approved these changes
Aug 11, 2025
workers-devprod
added
the
contribution
|
Congratulations @sibi361, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cme7i14t7117307l1d3zkoohz This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
thomasgauvin
pushed a commit
that referenced
this pull request
Aug 15, 2025
) * fix: correct noindex example URL pattern typo The previous example for matching `workers.dev` URLs under "Prevent your workers.dev URLs showing in search results" incorrectly used two splats, i.e. `*`, when only one splat can be used at maximum. This commit updates the example to use a single splat wildcard with a placeholder pattern that correctly matches both `workers.dev` URLs and Preview URLs. * fix: update noindex example URL pattern for `pages.dev` * Retrigger CI * Retrigger CI --------- Co-authored-by: Kody Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous example for matching
workers.devURLs under "Prevent your workers.dev URLs showing in search results" incorrectly used two "splats", i.e.*, when only one splat can be used at maximum.Addressing the above feedback raised in #23472, this PR updates the example to use a single splat wildcard with a placeholder pattern that correctly matches both
workers.devURLs and Preview URLs.closes #23472
Documentation checklist