-
Notifications
You must be signed in to change notification settings - Fork 10k
Restructure containers docs #24633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure containers docs #24633
Conversation
|
This PR requires additional review attention because it affects the following areas: RedirectsThis PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:
PartialsThis PR updates partial files, which are pieces of content used across multiple files in our Render component.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
58eb81c to
3ff3d87
Compare
| isolation from other workloads running on Cloudflare's network. Containers | ||
| should be built for the `linux/amd64` architecture, and should stay within | ||
| [size limits](/containers/platform-details/limits). [Logging](/containers/faq/#how-do-container-logs-work), metrics collection, and | ||
| networking are automatically set up on each container, if configured by the developer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice linking to enableInternet here (for networking).
| cleanup to ensure a graceful shutdown in this time. The container instance | ||
| will be rebooted elsewhere shortly after this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should say "restarted elsewhere" instead of "rebooted elsewhere". But even then this is not always the case, right? Sometimes a container shuts down, but doesn't get restarted somewhere else (e.g. when downscaling).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've done a lot of shuffling around, that probably made more sense in its original context. will remove here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, if say, max_instances was 2 and i only had 1 instance running (ie not downscalling), and the container had to shutdown for some reason, would it restart even if there was no new DO activity?
src/content/docs/containers/platform-details/environment-variables.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/containers/platform-details/environment-variables.mdx
Outdated
Show resolved
Hide resolved
d666e7e to
99fa4cd
Compare
99fa4cd to
0295f3e
Compare
Changes in this PR:
Before:
After:

I think this is better?