From 36ad05108f38cdb2de8a908ac22e8db614c83c39 Mon Sep 17 00:00:00 2001 From: Thomas Gauvin Date: Thu, 25 Sep 2025 11:27:31 -0400 Subject: [PATCH] remove sql.end/client.end() --- .../index.mdx | 2 -- .../databases/third-party-integrations/neon.mdx | 1 - .../hyperdrive/use-node-postgres-to-make-query.mdx | 11 ++++++----- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/content/docs/hyperdrive/tutorials/serverless-timeseries-api-with-timescale/index.mdx b/src/content/docs/hyperdrive/tutorials/serverless-timeseries-api-with-timescale/index.mdx index f79ede33c78d08c..2684d9d58fdcbff 100644 --- a/src/content/docs/hyperdrive/tutorials/serverless-timeseries-api-with-timescale/index.mdx +++ b/src/content/docs/hyperdrive/tutorials/serverless-timeseries-api-with-timescale/index.mdx @@ -203,7 +203,6 @@ export default { headers: { "Content-Type": "application/json" }, }); - ctx.waitUntil(client.end()); return resp; // Create a route for querying within a time-frame @@ -221,7 +220,6 @@ export default { headers: { "Content-Type": "application/json" }, }); - ctx.waitUntil(client.end()); return resp; } }, diff --git a/src/content/docs/workers/databases/third-party-integrations/neon.mdx b/src/content/docs/workers/databases/third-party-integrations/neon.mdx index f5f4eaded736059..4194fb7581a765f 100644 --- a/src/content/docs/workers/databases/third-party-integrations/neon.mdx +++ b/src/content/docs/workers/databases/third-party-integrations/neon.mdx @@ -81,7 +81,6 @@ To connect to Neon using `@neondatabase/serverless`, follow these steps: const client = new Client(env.DATABASE_URL); await client.connect(); const { rows } = await client.query("SELECT * FROM elements"); - ctx.waitUntil(client.end()); // this doesn’t hold up the response return new Response(JSON.stringify(rows)); }, diff --git a/src/content/partials/hyperdrive/use-node-postgres-to-make-query.mdx b/src/content/partials/hyperdrive/use-node-postgres-to-make-query.mdx index eef450ef3cbbda7..e2d7d4efd068638 100644 --- a/src/content/partials/hyperdrive/use-node-postgres-to-make-query.mdx +++ b/src/content/partials/hyperdrive/use-node-postgres-to-make-query.mdx @@ -29,7 +29,11 @@ Create a new `Client` instance and pass the Hyperdrive `connectionString`: import { Client } from "pg"; export default { - async fetch(request: Request, env: Env, ctx: ExecutionContext): Promise { + async fetch( + request: Request, + env: Env, + ctx: ExecutionContext, + ): Promise { // Create a new client instance for each request. const client = new Client({ connectionString: env.HYPERDRIVE.connectionString, @@ -43,9 +47,6 @@ export default { // Perform a simple query const result = await client.query("SELECT * FROM pg_tables"); - // Clean up the client after the response is returned, before the Worker is killed - ctx.waitUntil(client.end()); - return Response.json({ success: true, result: result.rows, @@ -53,7 +54,7 @@ export default { } catch (error: any) { console.error("Database error:", error.message); - new Response('Internal error occurred', { status: 500 }); + new Response("Internal error occurred", { status: 500 }); } }, };