Skip to content

remove sql.end/client.end() #25426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

remove sql.end/client.end() #25426

merged 1 commit into from
Sep 25, 2025

Conversation

@thomasgauvin
Copy link
Contributor

@thomasgauvin thomasgauvin commented Sep 25, 2025

No description provided.

@github-actions github-actions bot added product:hyperdrive Hyperdrive: https://developers.cloudflare.com/hyperdrive/ product:workers Related to Workers product September 2025 labels Sep 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

This PR requires additional review attention because it affects the following areas:

Partials

This PR updates partial files, which are pieces of content used across multiple files in our Render component.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/hyperdrive/ @elithrar, @thomasgauvin, @sejoker, @oxyjun, @cloudflare/pcx-technical-writing
/src/content/docs/workers/ @cloudflare/workers-docs, @GregBrimble, @irvinebroque, @mikenomitch, @korinne, @WalshyDev, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing, @kodster28, @cloudflare/wrangler, @cloudflare/workers-runtime-1
/src/content/partials/hyperdrive/ @elithrar, @thomasgauvin, @sejoker, @oxyjun, @cloudflare/pcx-technical-writing

@thomasgauvin thomasgauvin enabled auto-merge (squash) September 25, 2025 15:33
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Preview URL: https://36ad0510.preview.developers.cloudflare.com
Preview Branch URL: https://thomasgauvin-remove-sql-end.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/hyperdrive/tutorials/serverless-timeseries-api-with-timescale/ https://thomasgauvin-remove-sql-end.preview.developers.cloudflare.com/hyperdrive/tutorials/serverless-timeseries-api-with-timescale/
https://developers.cloudflare.com/workers/databases/third-party-integrations/neon/ https://thomasgauvin-remove-sql-end.preview.developers.cloudflare.com/workers/databases/third-party-integrations/neon/

irvinebroque
irvinebroque approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we tell people not to do this explicitly?

@thomasgauvin thomasgauvin merged commit 6683a39 into production Sep 25, 2025
11 checks passed
@thomasgauvin thomasgauvin deleted the thomasgauvin-remove-sql-end branch September 25, 2025 19:56
@thomasgauvin
Copy link
Contributor Author

thomasgauvin commented Sep 25, 2025 •
edited
Loading

should we tell people not to do this explicitly?

The memory of the fetch handler context is purged on every invocation, so Workers takes care of closing I/O context and therefore db connections (in the Worker memory).

It is ok to run ctx.waitUntil(sql.end()) which will close the connection between the Worker isolate and Hyperdrive, but we have had some folks report that this was causing issues, partly because of driver bugs that we've reported. To avoid this noise, we are not documenting it (and it's also simpler, as effective).

We are going to be writing a new doc section on how connections between Worker, Hyperdrive and the origin database work to clarify some of these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irvinebroque irvinebroque irvinebroque approved these changes

@Oxyjun Oxyjun Oxyjun approved these changes

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@mikenomitch mikenomitch Awaiting requested review from mikenomitch mikenomitch is a code owner

@korinne korinne Awaiting requested review from korinne korinne is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@kodster28 kodster28 Awaiting requested review from kodster28 kodster28 is a code owner

@elithrar elithrar Awaiting requested review from elithrar elithrar is a code owner

@sejoker sejoker Awaiting requested review from sejoker sejoker is a code owner

Assignees

@elithrar elithrar

@sejoker sejoker

@irvinebroque irvinebroque

@mikenomitch mikenomitch

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@kodster28 kodster28

@korinne korinne

@Oxyjun Oxyjun

Labels

product:hyperdrive Hyperdrive: https://developers.cloudflare.com/hyperdrive/ product:workers Related to Workers product September 2025 size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@thomasgauvin @irvinebroque @Oxyjun @elithrar @sejoker @mikenomitch @GregBrimble @WalshyDev @kodster28 @korinne