Skip to content

Conversation

@WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented Nov 4, 2025

Summary

As discussed in Chat, the modified on date for the sitemap is always set to the build time. This means that every entry is always seen as "updated" even though it hasn't been.
This is causing some issues in AI Search and is generally just not correct behaviour.

This updates it to using the Git modified on date and falling back to today if not possible

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
*.ts @cloudflare/pcx-content-engineering, @kodster28

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

@WalshyDev WalshyDev force-pushed the walshy/sitemap-accurate-modified-on branch from 0c874a6 to a9642e4 Compare November 4, 2025 10:42
@WalshyDev
Copy link
Member Author

This seems to work well, the only ones falling back to current time is the changelogs which makes sense. We can probably support those too but I think this is in a much better place now and happy with it as is :)

@WalshyDev WalshyDev marked this pull request as ready for review November 4, 2025 10:42
@WalshyDev WalshyDev requested review from a team, kathayl, kodster28 and mchenco as code owners November 4, 2025 10:42
@WalshyDev WalshyDev changed the title WIP: Test setting modified on by git date Set the sitemap modified on date to the last mod date in git Nov 4, 2025
@WalshyDev WalshyDev force-pushed the walshy/sitemap-accurate-modified-on branch from a9642e4 to 73b1476 Compare November 4, 2025 13:25
@WalshyDev WalshyDev merged commit 74f07e8 into production Nov 4, 2025
8 checks passed
@WalshyDev WalshyDev deleted the walshy/sitemap-accurate-modified-on branch November 4, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants