adding-product-event-subscriptions-via-components #26294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mia303
requested review from
a team,
GregBrimble,
Oxyjun,
aninibread,
celso,
craigsdennis,
elithrar,
harshil1712,
irvinebroque,
jonesphillip,
kodster28,
markdembo,
mchenco,
rita3ko,
rts-rob,
sejoker,
thomasgauvin,
vy-ton and
yomna-shousha
as code owners
github-actions
bot
added
November 2025
product:kv
product:queues
github-actions
bot
assigned
thomasgauvin,
harshil1712,
jonesphillip,
aninibread,
mchenco and
sejoker
irvinebroque
reviewed
Nov 4, 2025
Contributor
irvinebroque
left a comment
irvinebroque
left a comment
There was a problem hiding this comment.
Nice!!
do you still want review or mean to close this?
Contributor
Author
review would be great! thanks |
kodster28
requested changes
Nov 5, 2025
Collaborator
kodster28
left a comment
kodster28
left a comment
There was a problem hiding this comment.
Dropped a Q internally, but think we could accomplish the exact same behavior here through using partials as opposed to adding a new component / data source.
Let me know if you need any help / have Qs!
(also could likely use partials for the opening block of text you're re-using too)
kodster28
approved these changes
Nov 5, 2025
threepointone
pushed a commit
that referenced
this pull request
Nov 7, 2025
* adding-product-event-subscriptions-via-components * updating-links-and-formatting * fixing-compile-error * switching-to-partials * Added super slurper event schemas to r2, other minor changes --------- Co-authored-by: Phillip Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding references to event subscriptions in all documentation of product sources
Documentation checklist