Skip to content

Validate that no static redirect routes are declared after dynamic ones #26307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

Validate that no static redirect routes are declared after dynamic ones #26307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion bin/validate-redirects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ async function main() {
let numUrlsWithFragment = 0;
let numDuplicateRedirects = 0;
let numNonSlashedRedirects = 0;
let seenDynamicRedirects = false;
let numStaticRedirectsAfterDynamicRedirect = 0;

const validEndings = ["/", "*", ".xml", ".md", ".json", ".html", ".pdf"];

Expand All @@ -17,6 +19,17 @@ async function main() {

const [from, to] = line.split(" ");

if (from.includes("*")) {
seenDynamicRedirects = true;
}

if (seenDynamicRedirects && !from.includes("*")) {
console.log(
`✘ Found static redirect after dynamic redirect:\n ${from}`,
);
numStaticRedirectsAfterDynamicRedirect++;
}

if (from === to) {
console.log(`✘ Found infinite redirect:\n ${from} -> ${to}`);
numInfiniteRedirects++;
Expand Down Expand Up @@ -49,7 +62,8 @@ async function main() {
numInfiniteRedirects ||
numUrlsWithFragment ||
numDuplicateRedirects ||
numNonSlashedRedirects
numNonSlashedRedirects ||
numStaticRedirectsAfterDynamicRedirect
) {
console.log("\nDetected errors:");

Expand All @@ -71,6 +85,12 @@ async function main() {
);
}

if (numStaticRedirectsAfterDynamicRedirect > 0) {
console.log(
`- ${numStaticRedirectsAfterDynamicRedirect} static redirect(s) after dynamic redirect(s)`,
);
}

console.log("\nPlease fix the errors above before merging :)");
process.exit(1);
} else {
Expand Down