Skip to content

CODEOWNER and chore assignee changes #26379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

CODEOWNER and chore assignee changes #26379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ src/content/docs/smart-shield/ @RebeccaTamachiro @cloudflare/pcx-technical-writi

# Reference architecture

/src/content/docs/reference-architecture/ @securitypedant @haleycode @cloudflare/pcx-technical-writing
/src/assets/images/reference-architecture/ @securitypedant @haleycode @cloudflare/pcx-technical-writing
/src/content/docs/reference-architecture/ @securitypedant @cloudflare/pcx-technical-writing
/src/assets/images/reference-architecture/ @securitypedant @cloudflare/pcx-technical-writing

# Security products

Expand All @@ -211,7 +211,7 @@ src/content/docs/smart-shield/ @RebeccaTamachiro @cloudflare/pcx-technical-writi
/src/content/docs/firewall/ @pedrosousa @cloudflare/firewall @cloudflare/pcx-technical-writing
/src/content/docs/page-shield/ @pedrosousa @cloudflare/pcx-technical-writing
/src/content/docs/secrets-store/ @RebeccaTamachiro @cloudflare/pcx-technical-writing
/src/content/docs/security-center/ @jason-cf @cloudflare/pcx-technical-writing
/src/content/docs/security-center/ @cloudflare/pcx-technical-writing
/src/content/docs/ssl/ @RebeccaTamachiro @cloudflare/pcx-technical-writing
/src/content/docs/waf/ @pedrosousa @cloudflare/firewall @cloudflare/pcx-technical-writing
/src/content/docs/waf/change-log/ @pedrosousa @cloudflare/firewall @vs-mg @cloudflare/pcx-technical-writing
Expand Down
8 changes: 0 additions & 8 deletions .github/actions/assign-pr/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,6 @@ async function list(
assignees.add(owner.replace(/^@/, ""));
}
}
}
Copy link
Contributor

@pedrosousa pedrosousa Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to build the corresponding .js files due to these changes.

Copy link
Contributor

@pedrosousa pedrosousa Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must keep this closing curly bracket (closes the if block started above in line 74).


if (assignees.size === 0) {
// assign folks which will manually reassign
["haleycode", "pedrosousa", "dcpena", "patriciasantaana"].forEach(
(username) => assignees.add(username),
);
}

// don't self-assign
assignees.delete(author);
Expand Down
10 changes: 0 additions & 10 deletions .github/actions/issue-label-assign/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,6 @@ import * as codeOwnersUtils from "codeowners-utils";
assignees.add(owner.replace(/^@/, ""));
}
}
}
Copy link
Contributor

@pedrosousa pedrosousa Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must keep this closing curly bracket (closes the for loop started above in line 55).

console.log("Assignees are:");
console.log(assignees);

if (assignees.size === 0) {
// assign folks which will manually reassign
["haleycode", "pedrosousa", "dcpena", "patriciasantaana"].forEach(
(username) => assignees.add(username),
);
}

const client = github.getOctokit(token);

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/anchor-link-audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ jobs:
curl --silent -X POST -H "Authorization: Bearer $GITHUB_TOKEN" \
-H "Accept: application/vnd.github+json" \
"https://api.github.com/repos/$GITHUB_REPOSITORY/issues" \
-d "{\"title\": \"Broken Header Links Found\", \"body\": \"$(cat issue_body.txt)\", \"assignees\": [\"haleycode\"]}"
-d "{\"title\": \"Broken Header Links Found\", \"body\": \"$(cat issue_body.txt)\"}"
Loading