Skip to content

Commit 030b768

Browse files
tvarneychungthuang
authored andcommitted
DEVTOOLS-7936: Set permissions on public packages
This updates the public repository upload process to change the group on the uploaded files to `cf` and adds the write permission for members of the group. This should allow the `cf` user to properly overwrite the file when signing it.
1 parent f36dc6c commit 030b768

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ define publish_package
8989
for HOST in $(CF_PKG_HOSTS); do \
9090
ssh-keyscan -t rsa $$HOST >> ~/.ssh/known_hosts; \
9191
scp -4 cloudflared*.$(1) cfsync@$$HOST:/state/cf-pkg/staging/$(2)/$(TARGET_PUBLIC_REPO)/cloudflared/; \
92+
ssh cfsync@$$HOST 'chgrp cf /state/cf-pkg/staging/$(2)/$(TARGET_PUBLIC_REPO)/cloudflared/*.$(1) && chmod g+w /state/cf-pkg/staging/$(2)/$(TARGET_PUBLIC_REPO)/cloudflared/*.$(1)'; \
9293
done
9394
endef
9495

@@ -225,4 +226,4 @@ vet:
225226

226227
.PHONY: msi
227228
msi: cloudflared
228-
go-msi make --msi cloudflared.msi --version $(MSI_VERSION)
229+
go-msi make --msi cloudflared.msi --version $(MSI_VERSION)

0 commit comments

Comments
 (0)