Skip to content

Commit 337591b

Browse files
TUN-6414: Remove go-sumtype from cloudflared build process
This PR removes go-sumtype from cloudflared's build processes. The value we see from analysing exhaustive match patterns in go is minimal (we can do this in code reviews) compared to using a tool that is unmaintained and (now broken) in Go 1.18. We'd already been using the patched version here: https://github.com/sudarshan-reddy/go-sumtype because the original is broken for go tools > 1.16
1 parent fa6bcda commit 337591b

File tree

3 files changed

+0
-8
lines changed

3 files changed

+0
-8
lines changed

.github/workflows/check.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ jobs:
1212
uses: actions/setup-go@v2
1313
with:
1414
go-version: ${{ matrix.go-version }}
15-
- name: Install go-sumtype
16-
run: go get github.com/sudarshan-reddy/go-sumtype
1715
- name: Checkout code
1816
uses: actions/checkout@v2
1917
- name: Test

Makefile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -293,11 +293,6 @@ quic-deps:
293293
.PHONY: vet
294294
vet:
295295
go vet -mod=vendor ./...
296-
# go get github.com/sudarshan-reddy/go-sumtype (don't do this in build directory or this will cause vendor issues)
297-
# Note: If you have github.com/BurntSushi/go-sumtype then you might have to use the repo above instead
298-
# for now because it uses an older version of golang.org/x/tools.
299-
which go-sumtype
300-
go-sumtype $$(go list -mod=vendor ./...)
301296

302297
.PHONY: goimports
303298
goimports:

cfsetup.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ stretch: &stretch
153153
- gotest-to-teamcity
154154
pre-cache: &test_pre_cache
155155
- go get golang.org/x/tools/cmd/goimports
156-
- go get github.com/sudarshan-reddy/[email protected]
157156
post-cache:
158157
- export GOOS=linux
159158
- export GOARCH=amd64

0 commit comments

Comments
 (0)