Skip to content

Commit 4c1b895

Browse files
committed
DEVTOOLS-7936: Remove redundant chgrp from publish
This removes the redundant chgrp command from the publish step when pushing packages to our public repositories. The directory being pushed to has the setgid bit set on it, which means that we don't need to force the group using this command. Further, attempting to do so resulted in an error as the cfsync user does not have the appropriate permissions to use the chgrp command.
1 parent a1a554a commit 4c1b895

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ define publish_package
8989
for HOST in $(CF_PKG_HOSTS); do \
9090
ssh-keyscan -t rsa $$HOST >> ~/.ssh/known_hosts; \
9191
scp -4 cloudflared*.$(1) cfsync@$$HOST:/state/cf-pkg/staging/$(2)/$(TARGET_PUBLIC_REPO)/cloudflared/; \
92-
ssh cfsync@$$HOST 'chgrp cf /state/cf-pkg/staging/$(2)/$(TARGET_PUBLIC_REPO)/cloudflared/*.$(1) && chmod g+w /state/cf-pkg/staging/$(2)/$(TARGET_PUBLIC_REPO)/cloudflared/*.$(1)'; \
92+
ssh cfsync@$$HOST 'chmod g+w /state/cf-pkg/staging/$(2)/$(TARGET_PUBLIC_REPO)/cloudflared/*.$(1)'; \
9393
done
9494
endef
9595

0 commit comments

Comments
 (0)