TUN-6981: We should close UDP socket if failed to connecto to edge

joliveirinha · joliveirinha · commit 64f15d9992e0 · 2022-11-29T15:13:34.000Z
diff --git a/connection/quic.go b/connection/quic.go
@@ -81,6 +81,8 @@ func NewQUICConnection(
 
 	session, err := quic.Dial(udpConn, edgeAddr, edgeAddr.String(), tlsConfig, quicConfig)
 	if err != nil {
+		// close the udp server socket in case of error connecting to the edge
+		udpConn.Close()
 		return nil, &EdgeQuicDialError{Cause: err}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,8 @@ func NewQUICConnection(`
`81`	`81`
`82`	`82`	`session, err := quic.Dial(udpConn, edgeAddr, edgeAddr.String(), tlsConfig, quicConfig)`
`83`	`83`	`if err != nil {`
	`84`	`+ // close the udp server socket in case of error connecting to the edge`
	`85`	`+ udpConn.Close()`
`84`	`86`	`return nil, &EdgeQuicDialError{Cause: err}`
`85`	`87`	`}`
`86`	`88`