TUN-6811: Ping group range should be parsed as int32

chungthuang · chungthuang · commit 870193c06498 · 2022-09-29T12:59:38.000+01:00
diff --git a/ingress/icmp_linux.go b/ingress/icmp_linux.go
@@ -81,11 +81,11 @@ func checkInPingGroup() error {
 	// Example content: 999	   59999
 	found := findGroupIDRegex.FindAll(file, 2)
 	if len(found) == 2 {
-		groupMin, err := strconv.ParseUint(string(found[0]), 10, 16)
+		groupMin, err := strconv.ParseInt(string(found[0]), 10, 32)
 		if err != nil {
 			return errors.Wrapf(err, "failed to determine minimum ping group ID")
 		}
-		groupMax, err := strconv.ParseUint(string(found[1]), 10, 16)
+		groupMax, err := strconv.ParseInt(string(found[1]), 10, 32)
 		if err != nil {
 			return errors.Wrapf(err, "failed to determine minimum ping group ID")
 		}

Original file line number	Diff line number	Diff line change
`@@ -81,11 +81,11 @@ func checkInPingGroup() error {`
`81`	`81`	`// Example content: 999 59999`
`82`	`82`	`found := findGroupIDRegex.FindAll(file, 2)`
`83`	`83`	`if len(found) == 2 {`
`84`		`- groupMin, err := strconv.ParseUint(string(found[0]), 10, 16)`
	`84`	`+ groupMin, err := strconv.ParseInt(string(found[0]), 10, 32)`
`85`	`85`	`if err != nil {`
`86`	`86`	`return errors.Wrapf(err, "failed to determine minimum ping group ID")`
`87`	`87`	`}`
`88`		`- groupMax, err := strconv.ParseUint(string(found[1]), 10, 16)`
	`88`	`+ groupMax, err := strconv.ParseInt(string(found[1]), 10, 32)`
`89`	`89`	`if err != nil {`
`90`	`90`	`return errors.Wrapf(err, "failed to determine minimum ping group ID")`
`91`	`91`	`}`