TUN-6460: Rename metric label location to edge_location

DevinCarr · DevinCarr · commit b849def673f5 · 2022-06-24T09:46:22.000-07:00
For Google's managed prometheus, it seems they reserved certain
labels for their internal service regions/locations. This causes
customers to run into issues using our metrics since our
metric: `cloudflared_tunnel_server_locations` has a `location`
label. Renaming this to `edge_location` should unblock the
conflict and usage.
diff --git a/connection/metrics.go b/connection/metrics.go
@@ -367,7 +367,7 @@ func initTunnelMetrics() *tunnelMetrics {
 			Name:      "server_locations",
 			Help:      "Where each tunnel is connected to. 1 means current location, 0 means previous locations.",
 		},
-		[]string{"connection_id", "location"},
+		[]string{"connection_id", "edge_location"},
 	)
 	prometheus.MustRegister(serverLocations)
 

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,7 @@ func initTunnelMetrics() *tunnelMetrics {`
`367`	`367`	`Name: "server_locations",`
`368`	`368`	`Help: "Where each tunnel is connected to. 1 means current location, 0 means previous locations.",`
`369`	`369`	`},`
`370`		`- []string{"connection_id", "location"},`
	`370`	`+ []string{"connection_id", "edge_location"},`
`371`	`371`	`)`
`372`	`372`	`prometheus.MustRegister(serverLocations)`
`373`	`373`