TUN-7097: Fix bug checking proxy-dns config on tunnel cmd execution

joliveirinha · joliveirinha · commit bd917d294cb1 · 2023-01-22T19:17:06.000Z
diff --git a/cmd/cloudflared/tunnel/cmd.go b/cmd/cloudflared/tunnel/cmd.go
@@ -195,7 +195,7 @@ func TunnelCommand(c *cli.Context) error {
 		return runClassicTunnel(sc)
 	}
 
-	if c.String("proxy-dns") != "" {
+	if c.IsSet("proxy-dns") {
 		// NamedTunnelProperties are nil since proxy dns server does not need it.
 		// This is supported for legacy reasons: dns proxy server is not a tunnel and ideally should
 		// not run as part of cloudflared tunnel.

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ func TunnelCommand(c *cli.Context) error {`
`195`	`195`	`return runClassicTunnel(sc)`
`196`	`196`	`}`
`197`	`197`
`198`		`- if c.String("proxy-dns") != "" {`
	`198`	`+ if c.IsSet("proxy-dns") {`
`199`	`199`	`// NamedTunnelProperties are nil since proxy dns server does not need it.`
`200`	`200`	`// This is supported for legacy reasons: dns proxy server is not a tunnel and ideally should`
`201`	`201`	`// not run as part of cloudflared tunnel.`