Skip to content

Commit c13b6df

Browse files
TUN-7003: Tempoarily disable erroneous notarize-app
This PR temporarily disables the xcrun notarize-app feature since this is soemthing we've historically had broken. However, what changed now is we set -e for the mac os scripts. We'll need to remove this to unblock mac builds. We could spend time as part of https://jira.cfdata.org/browse/TUN-5789 to look into this.
1 parent b8b35d9 commit c13b6df

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

.teamcity/build-macos.sh

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -142,13 +142,8 @@ fi
142142
if [[ ! -z "$CODE_SIGN_NAME" ]]; then
143143
codesign -s "${CODE_SIGN_NAME}" -f -v --timestamp --options runtime ${BINARY_NAME}
144144

145-
# notarize the binary
146-
if [[ ! -z "$CFD_NOTE_PASSWORD" ]]; then
147-
zip "${BINARY_NAME}.zip" ${BINARY_NAME}
148-
xcrun altool --notarize-app -f "${BINARY_NAME}.zip" -t osx -u ${CFD_NOTE_USERNAME} -p ${CFD_NOTE_PASSWORD} --primary-bundle-id ${BUNDLE_ID}
149-
fi
150-
fi
151-
145+
# notarize the binary
146+
# TODO: https://jira.cfdata.org/browse/TUN-5789
152147

153148
# creating build directory
154149
rm -rf $TARGET_DIRECTORY
@@ -173,10 +168,7 @@ if [[ ! -z "$PKG_SIGN_NAME" ]]; then
173168
${PKGNAME}
174169

175170
# notarize the package
176-
if [[ ! -z "$CFD_NOTE_PASSWORD" ]]; then
177-
xcrun altool --notarize-app -f ${PKGNAME} -t osx -u ${CFD_NOTE_USERNAME} -p ${CFD_NOTE_PASSWORD} --primary-bundle-id ${BUNDLE_ID}
178-
xcrun stapler staple ${PKGNAME}
179-
fi
171+
# TODO: https://jira.cfdata.org/browse/TUN-5789
180172
else
181173
pkgbuild --identifier com.cloudflare.${PRODUCT} \
182174
--version ${VERSION} \

0 commit comments

Comments
 (0)